diff mbox series

[PULL,08/10] target/s390x: Only compile decode_basedisp() on system-mode

Message ID 20200605153756.392825-9-cohuck@redhat.com
State New
Headers show
Series [PULL,01/10] s390x/kvm: help valgrind in several places | expand

Commit Message

Cornelia Huck June 5, 2020, 3:37 p.m. UTC 
From: Philippe Mathieu-Daudé <f4bug@amsat.org>

The decode_basedisp*() methods are only used in ioinst.c,
which is only build in system-mode emulation.

I/O instructions are privileged, and other S instructions
are decoded elsewhere.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20200526172427.17460-6-f4bug@amsat.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/internal.h | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/target/s390x/internal.h b/target/s390x/internal.h
index 8c95c734dbe9..c1678dc6bc8b 100644
--- a/target/s390x/internal.h
+++ b/target/s390x/internal.h
@@ -204,6 +204,8 @@  enum cc_op {
     CC_OP_MAX
 };
 
+#ifndef CONFIG_USER_ONLY
+
 static inline hwaddr decode_basedisp_s(CPUS390XState *env, uint32_t ipb,
                                        uint8_t *ar)
 {
@@ -225,6 +227,8 @@  static inline hwaddr decode_basedisp_s(CPUS390XState *env, uint32_t ipb,
 /* Base/displacement are at the same locations. */
 #define decode_basedisp_rs decode_basedisp_s
 
+#endif /* CONFIG_USER_ONLY */
+
 /* arch_dump.c */
 int s390_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs,
                               int cpuid, void *opaque);