diff mbox

[Xen-devel,osstest.git] ts-xen-build: remove frobbing of xen.git/buildconfigs/enable-xen-config

Message ID 1397471460-19047-1-git-send-email-ian.campbell@citrix.com
State New
Headers show

Commit Message

Ian Campbell April 14, 2014, 10:31 a.m. UTC
This shouldn't be touched since osstest.git commit c1fba9810435 "import
enable-xen-config from xen.git, use for ts-kernel-build" and is just wrong
since xen.git 40305629dc48 "build: remove Linux kernel build integration."
since the file no longer exists.

Of the options which were being set here only CONFIG_HIGHPTE isn't already
handled by ts-kernel-build. I don't think CONFIG_HIGHPTE needs to be forced to
off these days (pvops kernels do it automagically). If I'm wrong I'm sure
osstest will tell us...

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>
---
 ts-xen-build | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Ian Jackson April 14, 2014, 10:57 a.m. UTC | #1
Ian Campbell writes ("[PATCH osstest.git] ts-xen-build: remove frobbing of xen.git/buildconfigs/enable-xen-config"):
> This shouldn't be touched since osstest.git commit c1fba9810435 "import
> enable-xen-config from xen.git, use for ts-kernel-build" and is just wrong
> since xen.git 40305629dc48 "build: remove Linux kernel build integration."
> since the file no longer exists.
> 
> Of the options which were being set here only CONFIG_HIGHPTE isn't
> already handled by ts-kernel-build. I don't think CONFIG_HIGHPTE
> needs to be forced to off these days (pvops kernels do it
> automagically). If I'm wrong I'm sure osstest will tell us...

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff mbox

Patch

diff --git a/ts-xen-build b/ts-xen-build
index e67e29c..babe5da 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -94,16 +94,6 @@  END
 }
 
 sub build () {
-    target_cmd_build($ho, 1000, $builddir, <<END);
-        cd xen-unstable
-        perl -i.bak -pe '
-		next unless m/^exit 0/;
-                print "setopt CONFIG_HIGHPTE n\\n" or die \$!;
-                print "setopt CONFIG_TUN y\\n" or die \$!;
-                print "setopt CONFIG_BLK_DEV_NBD m\\n" or die \$!;
-                print "setopt CONFIG_DEBUG_INFO y\\n" or die \$!;
-        ' buildconfigs/enable-xen-config
-END
     my $xend_opt= $r{enable_xend} =~ m/true/ ? "--enable-xend" : "--disable-xend";
     my $ovmf_opt= $r{enable_ovmf} =~ m/true/ ? "--enable-ovmf" : "--disable-ovmf";