diff mbox series

ASoC: qcom: MSM8996 depends on COMMON_CLK

Message ID 548bb7f8-672d-3d95-0d78-cef1c9837a42@infradead.org
State New
Headers show
Series ASoC: qcom: MSM8996 depends on COMMON_CLK | expand

Commit Message

Randy Dunlap Oct. 16, 2020, 5:39 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix a kconfig warning in sound/soc/qcom:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
  Selected by [y]:
  - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]

This is needed because 'select' does not follow dependency chains.

Fixes: a6f933f63f2f ("ASoC: qcom: apq8096: Add db820c machine driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
---
Found in linux-next but applies to mainline.

 sound/soc/qcom/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Randy Dunlap Oct. 30, 2020, 6:31 p.m. UTC | #1 
On 10/16/20 10:39 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix a kconfig warning in sound/soc/qcom:
> 
> WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
>   Selected by [y]:
>   - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]
> 
> This is needed because 'select' does not follow dependency chains.
> 
> Fixes: a6f933f63f2f ("ASoC: qcom: apq8096: Add db820c machine driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org
> ---
> Found in linux-next but applies to mainline.
> 
>  sound/soc/qcom/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20201016.orig/sound/soc/qcom/Kconfig
> +++ linux-next-20201016/sound/soc/qcom/Kconfig
> @@ -106,6 +106,7 @@ config SND_SOC_QDSP6
>  config SND_SOC_MSM8996
>  	tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
>  	depends on QCOM_APR
> +	depends on COMMON_CLK
>  	select SND_SOC_QDSP6
>  	select SND_SOC_QCOM_COMMON
>  	help
> 

Ping. I am still seeing this kconfig warning in linux-next 20201030.
diff mbox series

Patch

--- linux-next-20201016.orig/sound/soc/qcom/Kconfig
+++ linux-next-20201016/sound/soc/qcom/Kconfig
@@ -106,6 +106,7 @@  config SND_SOC_QDSP6
 config SND_SOC_MSM8996
 	tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
 	depends on QCOM_APR
+	depends on COMMON_CLK
 	select SND_SOC_QDSP6
 	select SND_SOC_QCOM_COMMON
 	help