selftests/powerpc/eeh: disable kselftest timeout setting for eeh-basic

The eeh-basic test got its own 60 seconds timeout (defined in commit
414f50434aa2 "selftests/eeh: Bump EEH wait time to 60s") per breakable
device.

And we have discovered that the number of breakable devices varies
on different hardware. The device recovery time ranges from 0 to 35
seconds. In our test pool it will take about 30 seconds to run on a
Power8 system that with 5 breakable devices, 60 seconds to run on a
Power9 system that with 4 breakable devices.

Thus it's better to disable the default 45 seconds timeout setting in
the kselftest framework to give it a chance to finish. And let the
test to take care of the timeout control.

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
 tools/testing/selftests/powerpc/eeh/Makefile | 2 +-
 tools/testing/selftests/powerpc/eeh/settings | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/powerpc/eeh/settings

Po-Hsu Lin <po-hsu.lin@canonical.com> writes:
> The eeh-basic test got its own 60 seconds timeout (defined in commit
> 414f50434aa2 "selftests/eeh: Bump EEH wait time to 60s") per breakable
> device.
>
> And we have discovered that the number of breakable devices varies
> on different hardware. The device recovery time ranges from 0 to 35
> seconds. In our test pool it will take about 30 seconds to run on a
> Power8 system that with 5 breakable devices, 60 seconds to run on a
> Power9 system that with 4 breakable devices.
>
> Thus it's better to disable the default 45 seconds timeout setting in
> the kselftest framework to give it a chance to finish. And let the
> test to take care of the timeout control.

I'd prefer if we still had some timeout, maybe 5 or 10 minutes? Just in
case the test goes completely bonkers.

cheers

> diff --git a/tools/testing/selftests/powerpc/eeh/Makefile b/tools/testing/selftests/powerpc/eeh/Makefile
> index b397bab..ae963eb 100644
> --- a/tools/testing/selftests/powerpc/eeh/Makefile
> +++ b/tools/testing/selftests/powerpc/eeh/Makefile
> @@ -3,7 +3,7 @@ noarg:
>  	$(MAKE) -C ../
>  
>  TEST_PROGS := eeh-basic.sh
> -TEST_FILES := eeh-functions.sh
> +TEST_FILES := eeh-functions.sh settings
>  
>  top_srcdir = ../../../../..
>  include ../../lib.mk
> diff --git a/tools/testing/selftests/powerpc/eeh/settings b/tools/testing/selftests/powerpc/eeh/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/powerpc/eeh/settings
> @@ -0,0 +1 @@
> +timeout=0
> -- 
> 2.7.4

On Fri, Oct 23, 2020 at 10:07 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>

> Po-Hsu Lin <po-hsu.lin@canonical.com> writes:

> > The eeh-basic test got its own 60 seconds timeout (defined in commit

> > 414f50434aa2 "selftests/eeh: Bump EEH wait time to 60s") per breakable

> > device.

> >

> > And we have discovered that the number of breakable devices varies

> > on different hardware. The device recovery time ranges from 0 to 35

> > seconds. In our test pool it will take about 30 seconds to run on a

> > Power8 system that with 5 breakable devices, 60 seconds to run on a

> > Power9 system that with 4 breakable devices.

> >

> > Thus it's better to disable the default 45 seconds timeout setting in

> > the kselftest framework to give it a chance to finish. And let the

> > test to take care of the timeout control.

>

> I'd prefer if we still had some timeout, maybe 5 or 10 minutes? Just in

> case the test goes completely bonkers.

>

OK, let's go for 5 minutes.
Will send V2 later.
Thanks for your suggestion!

> cheers

>

> > diff --git a/tools/testing/selftests/powerpc/eeh/Makefile b/tools/testing/selftests/powerpc/eeh/Makefile

> > index b397bab..ae963eb 100644

> > --- a/tools/testing/selftests/powerpc/eeh/Makefile

> > +++ b/tools/testing/selftests/powerpc/eeh/Makefile

> > @@ -3,7 +3,7 @@ noarg:

> >       $(MAKE) -C ../

> >

> >  TEST_PROGS := eeh-basic.sh

> > -TEST_FILES := eeh-functions.sh

> > +TEST_FILES := eeh-functions.sh settings

> >

> >  top_srcdir = ../../../../..

> >  include ../../lib.mk

> > diff --git a/tools/testing/selftests/powerpc/eeh/settings b/tools/testing/selftests/powerpc/eeh/settings

> > new file mode 100644

> > index 0000000..e7b9417

> > --- /dev/null

> > +++ b/tools/testing/selftests/powerpc/eeh/settings

> > @@ -0,0 +1 @@

> > +timeout=0

> > --

> > 2.7.4