| Message ID | 1603248250-24847-1-git-send-email-bingbu.cao@intel.com |
|---|---|
| State | Accepted |
| Commit | 1d7b18a9ee5513fe45175ccb8a29ae08ad110fb2 |
| Headers | show |
| Series | media: ov2740: change the minimal exposure value to 4 | expand |
Hi Bingbu, On Wed, Oct 21, 2020 at 10:44:10AM +0800, Bingbu Cao wrote: > The minimal valid exposure value should be 4 lines instead of 8 for > ov2740 mannual exposure control. > > Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> > --- > drivers/media/i2c/ov2740.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c > index bd0d45b0d43f..0dbae4949cb3 100644 > --- a/drivers/media/i2c/ov2740.c > +++ b/drivers/media/i2c/ov2740.c > @@ -37,7 +37,7 @@ > > /* Exposure controls from sensor */ > #define OV2740_REG_EXPOSURE 0x3500 > -#define OV2740_EXPOSURE_MIN 8 > +#define OV2740_EXPOSURE_MIN 4 > #define OV2740_EXPOSURE_MAX_MARGIN 8 > #define OV2740_EXPOSURE_STEP 1 This is already in my tree --- I may forgotten to push master after applying many patches, it is up-to-date now. -- Regards, Sakari Ailus
Sakari, thanks. I did not find that on patchwork, so resend it again. :) On 10/21/20 5:20 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Wed, Oct 21, 2020 at 10:44:10AM +0800, Bingbu Cao wrote: >> The minimal valid exposure value should be 4 lines instead of 8 for >> ov2740 mannual exposure control. >> >> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> >> --- >> drivers/media/i2c/ov2740.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c >> index bd0d45b0d43f..0dbae4949cb3 100644 >> --- a/drivers/media/i2c/ov2740.c >> +++ b/drivers/media/i2c/ov2740.c >> @@ -37,7 +37,7 @@ >> >> /* Exposure controls from sensor */ >> #define OV2740_REG_EXPOSURE 0x3500 >> -#define OV2740_EXPOSURE_MIN 8 >> +#define OV2740_EXPOSURE_MIN 4 >> #define OV2740_EXPOSURE_MAX_MARGIN 8 >> #define OV2740_EXPOSURE_STEP 1 > > This is already in my tree --- I may forgotten to push master after > applying many patches, it is up-to-date now. > -- Best regards, Bingbu Cao
Hi Bingbu, On Wed, Oct 21, 2020 at 06:12:16PM +0800, Bingbu Cao wrote: > Sakari, thanks. > I did not find that on patchwork, so resend it again. :) That patch simply seems to have been lost. It's also not on the list, only in my inbox. We've had e-mail delivery problems recently both ways, I suppose this is attributable to those. Thanks for resending so others could also see it.
diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index bd0d45b0d43f..0dbae4949cb3 100644 --- a/drivers/media/i2c/ov2740.c +++ b/drivers/media/i2c/ov2740.c @@ -37,7 +37,7 @@ /* Exposure controls from sensor */ #define OV2740_REG_EXPOSURE 0x3500 -#define OV2740_EXPOSURE_MIN 8 +#define OV2740_EXPOSURE_MIN 4 #define OV2740_EXPOSURE_MAX_MARGIN 8 #define OV2740_EXPOSURE_STEP 1
The minimal valid exposure value should be 4 lines instead of 8 for ov2740 mannual exposure control. Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> --- drivers/media/i2c/ov2740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)