[v8,2/3] dt-bindings: arm: cpus: Document 'mediatek,freq-domain' property

Message ID 1603700349-5922-3-git-send-email-hector.yuan@mediatek.com
State New
Headers show
Series
  • Untitled series #62485
Related show

Commit Message

Hector Yuan Oct. 26, 2020, 8:19 a.m.
From: "Hector.Yuan" <hector.yuan@mediatek.com>


Add devicetree documentation for 'mediatek,freq-domain' property specific
to Mediatek CPUs. This property is used to reference the CPUFREQ node
along with the domain id.

Signed-off-by: Hector.Yuan <hector.yuan@mediatek.com>

---
 Documentation/devicetree/bindings/arm/cpus.yaml |    6 ++++++
 1 file changed, 6 insertions(+)

-- 
1.7.9.5

Comments

Rob Herring Oct. 28, 2020, 3:08 p.m. | #1
On Mon, Oct 26, 2020 at 04:19:08PM +0800, Hector Yuan wrote:
> From: "Hector.Yuan" <hector.yuan@mediatek.com>

> 

> Add devicetree documentation for 'mediatek,freq-domain' property specific

> to Mediatek CPUs. This property is used to reference the CPUFREQ node

> along with the domain id.

> 

> Signed-off-by: Hector.Yuan <hector.yuan@mediatek.com>

> ---

>  Documentation/devicetree/bindings/arm/cpus.yaml |    6 ++++++

>  1 file changed, 6 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml

> index 1222bf1..e995b26 100644

> --- a/Documentation/devicetree/bindings/arm/cpus.yaml

> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml

> @@ -255,6 +255,12 @@ properties:

>  

>        where voltage is in V, frequency is in MHz.

>  

> +  mediatek,freq-domain:

> +    $ref: '/schemas/types.yaml#/definitions/phandle-array'

> +    description:

> +      CPUs supporting freq-domain must set their "mediatek,freq-domain" property

> +      with phandle to a cpufreq_hw node followed by the domain id.


This needs to be a common binding shared with SCMI domains.

> +

>    power-domains:

>      $ref: '/schemas/types.yaml#/definitions/phandle-array'

>      description:

> -- 

> 1.7.9.5
Lukasz Luba Nov. 19, 2020, 3:23 p.m. | #2
On 10/28/20 3:08 PM, Rob Herring wrote:
> On Mon, Oct 26, 2020 at 04:19:08PM +0800, Hector Yuan wrote:

>> From: "Hector.Yuan" <hector.yuan@mediatek.com>

>>

>> Add devicetree documentation for 'mediatek,freq-domain' property specific

>> to Mediatek CPUs. This property is used to reference the CPUFREQ node

>> along with the domain id.

>>

>> Signed-off-by: Hector.Yuan <hector.yuan@mediatek.com>

>> ---

>>   Documentation/devicetree/bindings/arm/cpus.yaml |    6 ++++++

>>   1 file changed, 6 insertions(+)

>>

>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml

>> index 1222bf1..e995b26 100644

>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml

>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml

>> @@ -255,6 +255,12 @@ properties:

>>   

>>         where voltage is in V, frequency is in MHz.

>>   

>> +  mediatek,freq-domain:

>> +    $ref: '/schemas/types.yaml#/definitions/phandle-array'

>> +    description:

>> +      CPUs supporting freq-domain must set their "mediatek,freq-domain" property

>> +      with phandle to a cpufreq_hw node followed by the domain id.

> 

> This needs to be a common binding shared with SCMI domains.


Would it be accurate to create a new binding file:
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.txt
?

There is already cpufreq-qcom-hw.txt with 'qcom,freq-domain'
and analogous purpose.

Regards,
Lukasz
Sudeep Holla Nov. 19, 2020, 5:13 p.m. | #3
On Thu, Nov 19, 2020 at 03:23:20PM +0000, Lukasz Luba wrote:
> 

> 

> On 10/28/20 3:08 PM, Rob Herring wrote:

> > On Mon, Oct 26, 2020 at 04:19:08PM +0800, Hector Yuan wrote:

> > > From: "Hector.Yuan" <hector.yuan@mediatek.com>

> > > 

> > > Add devicetree documentation for 'mediatek,freq-domain' property specific

> > > to Mediatek CPUs. This property is used to reference the CPUFREQ node

> > > along with the domain id.

> > > 

> > > Signed-off-by: Hector.Yuan <hector.yuan@mediatek.com>

> > > ---

> > >   Documentation/devicetree/bindings/arm/cpus.yaml |    6 ++++++

> > >   1 file changed, 6 insertions(+)

> > > 

> > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml

> > > index 1222bf1..e995b26 100644

> > > --- a/Documentation/devicetree/bindings/arm/cpus.yaml

> > > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml

> > > @@ -255,6 +255,12 @@ properties:

> > >         where voltage is in V, frequency is in MHz.

> > > +  mediatek,freq-domain:

> > > +    $ref: '/schemas/types.yaml#/definitions/phandle-array'

> > > +    description:

> > > +      CPUs supporting freq-domain must set their "mediatek,freq-domain" property

> > > +      with phandle to a cpufreq_hw node followed by the domain id.

> > 

> > This needs to be a common binding shared with SCMI domains.

> 

> Would it be accurate to create a new binding file:

> Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.txt

> ?

>


Nope, Rob already asked to unify all such bindings and generalise it.
Here is my attempt[1] and this must just use it or help to enhance that
in order to make use of that binding.

-- 
Regards,
Sudeep

[1] https://lore.kernel.org/lkml/20201116181356.804590-1-sudeep.holla@arm.com
Lukasz Luba Nov. 20, 2020, 8:35 a.m. | #4
On 11/19/20 5:13 PM, Sudeep Holla wrote:
> On Thu, Nov 19, 2020 at 03:23:20PM +0000, Lukasz Luba wrote:
>>
>>
>> On 10/28/20 3:08 PM, Rob Herring wrote:
>>> On Mon, Oct 26, 2020 at 04:19:08PM +0800, Hector Yuan wrote:
>>>> From: "Hector.Yuan" <hector.yuan@mediatek.com>
>>>>
>>>> Add devicetree documentation for 'mediatek,freq-domain' property specific
>>>> to Mediatek CPUs. This property is used to reference the CPUFREQ node
>>>> along with the domain id.
>>>>
>>>> Signed-off-by: Hector.Yuan <hector.yuan@mediatek.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/arm/cpus.yaml |    6 ++++++
>>>>    1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
>>>> index 1222bf1..e995b26 100644
>>>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
>>>> @@ -255,6 +255,12 @@ properties:
>>>>          where voltage is in V, frequency is in MHz.
>>>> +  mediatek,freq-domain:
>>>> +    $ref: '/schemas/types.yaml#/definitions/phandle-array'
>>>> +    description:
>>>> +      CPUs supporting freq-domain must set their "mediatek,freq-domain" property
>>>> +      with phandle to a cpufreq_hw node followed by the domain id.
>>>
>>> This needs to be a common binding shared with SCMI domains.
>>
>> Would it be accurate to create a new binding file:
>> Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.txt
>> ?
>>
> 
> Nope, Rob already asked to unify all such bindings and generalise it.
> Here is my attempt[1] and this must just use it or help to enhance that
> in order to make use of that binding.
> 

That's great. Thank you for the information.

Regards,
Lukasz

Patch

diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
index 1222bf1..e995b26 100644
--- a/Documentation/devicetree/bindings/arm/cpus.yaml
+++ b/Documentation/devicetree/bindings/arm/cpus.yaml
@@ -255,6 +255,12 @@  properties:
 
       where voltage is in V, frequency is in MHz.
 
+  mediatek,freq-domain:
+    $ref: '/schemas/types.yaml#/definitions/phandle-array'
+    description:
+      CPUs supporting freq-domain must set their "mediatek,freq-domain" property
+      with phandle to a cpufreq_hw node followed by the domain id.
+
   power-domains:
     $ref: '/schemas/types.yaml#/definitions/phandle-array'
     description: