diff mbox

[Xen-devel,v4,02/21] xen/arm: Constify address pointer for cache helpers

Message ID 1398172475-27873-3-git-send-email-julien.grall@linaro.org
State Accepted, archived
Headers show

Commit Message

Julien Grall April 22, 2014, 1:14 p.m. UTC 
The memory pointed by this pointer is not modified in clean_xen_dcache_va_range
and clean_and_invalidate_xen_dcache_va_range.

Constify it. This will allow us to use theses helpers later in code which use
const.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
 xen/include/asm-arm/page.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Ian Campbell April 28, 2014, 1:52 p.m. UTC | #1 
On Tue, 2014-04-22 at 14:14 +0100, Julien Grall wrote:
> The memory pointed by this pointer is not modified in clean_xen_dcache_va_range
> and clean_and_invalidate_xen_dcache_va_range.
> 
> Constify it. This will allow us to use theses helpers later in code which use
> const.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Acked-by: Ian Campbell <ian.campbell@citrix.com>
diff mbox

Patch

diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
index 0c0fd37..c38e9c9 100644
--- a/xen/include/asm-arm/page.h
+++ b/xen/include/asm-arm/page.h
@@ -260,9 +260,9 @@  extern size_t cacheline_bytes;
 /* Functions for flushing medium-sized areas.
  * if 'range' is large enough we might want to use model-specific
  * full-cache flushes. */
-static inline void clean_xen_dcache_va_range(void *p, unsigned long size)
+static inline void clean_xen_dcache_va_range(const void *p, unsigned long size)
 {
-    void *end;
+    const void *end;
     dsb(sy);           /* So the CPU issues all writes to the range */
     for ( end = p + size; p < end; p += cacheline_bytes )
         asm volatile (__clean_xen_dcache_one(0) : : "r" (p));
@@ -270,9 +270,9 @@  static inline void clean_xen_dcache_va_range(void *p, unsigned long size)
 }
 
 static inline void clean_and_invalidate_xen_dcache_va_range
-    (void *p, unsigned long size)
+    (const void *p, unsigned long size)
 {
-    void *end;
+    const void *end;
     dsb(sy);         /* So the CPU issues all writes to the range */
     for ( end = p + size; p < end; p += cacheline_bytes )
         asm volatile (__clean_and_invalidate_xen_dcache_one(0) : : "r" (p));