| Message ID | 20201019181059.22634-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | net: chelsio: inline_crypto: fix Kconfig and build errors | expand |
On Mon, 19 Oct 2020 11:10:59 -0700 Randy Dunlap wrote: > Fix build errors when TLS=m, TLS_TOE=y, and CRYPTO_DEV_CHELSIO_TLS=y. > > Having (tristate) CRYPTO_DEV_CHELSIO_TLS depend on (bool) TLS_TOE > is not strong enough to prevent the bad combination of TLS=m and > CRYPTO_DEV_CHELSIO_TLS=y, so add a dependency on TLS to prevent the > problematic kconfig combination. > > Fixes these build errors: > > hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_free_uld': > drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:165: undefined reference to `tls_toe_unregister_device' > hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_register_dev': > drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:204: undefined reference to `tls_toe_register_device' > > Fixes: 44fd1c1fd821 ("chelsio/chtls: separate chelsio tls driver from crypto driver") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Applied, thanks Randy! But I swapped the Fixes tag for: Fixes: 53b4414a7003 ("net/tls: allow compiling TLS TOE out")
--- linux-next-20201016.orig/drivers/net/ethernet/chelsio/inline_crypto/Kconfig +++ linux-next-20201016/drivers/net/ethernet/chelsio/inline_crypto/Kconfig @@ -16,6 +16,7 @@ if CHELSIO_INLINE_CRYPTO config CRYPTO_DEV_CHELSIO_TLS tristate "Chelsio Crypto Inline TLS Driver" depends on CHELSIO_T4 + depends on TLS depends on TLS_TOE help Support Chelsio Inline TLS with Chelsio crypto accelerator.
Fix build errors when TLS=m, TLS_TOE=y, and CRYPTO_DEV_CHELSIO_TLS=y. Having (tristate) CRYPTO_DEV_CHELSIO_TLS depend on (bool) TLS_TOE is not strong enough to prevent the bad combination of TLS=m and CRYPTO_DEV_CHELSIO_TLS=y, so add a dependency on TLS to prevent the problematic kconfig combination. Fixes these build errors: hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_free_uld': drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:165: undefined reference to `tls_toe_unregister_device' hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_register_dev': drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:204: undefined reference to `tls_toe_register_device' Fixes: 44fd1c1fd821 ("chelsio/chtls: separate chelsio tls driver from crypto driver") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Vinay Kumar Yadav <vinay.yadav@chelsio.com> Cc: netdev@vger.kernel.org Cc: Ayush Sawal <ayush.sawal@chelsio.com> Cc: Rohit Maheshwari <rohitm@chelsio.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> --- drivers/net/ethernet/chelsio/inline_crypto/Kconfig | 1 + 1 file changed, 1 insertion(+)