| Message ID | 20201003093051.7242-2-kurt@linutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,1/2] dt-bindings: net: dsa: b53: Specify unit address in hex | expand |
On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote: > There is no such property as duplex-full. It's called full-duplex. Leading to > reduced speed when using the example as base for a real device tree. Doh, thanks for correcting this. Would you want to make this a YAML binding at some point? I can take care of it if you do not have time to do it. > > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
From: Kurt Kanzenbach <kurt@linutronix.de> Date: Sat, 3 Oct 2020 11:30:51 +0200 > There is no such property as duplex-full. It's called full-duplex. Leading to > reduced speed when using the example as base for a real device tree. > > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> Applied.
On Sat Oct 03 2020, Florian Fainelli wrote: > On 10/3/2020 2:30 AM, Kurt Kanzenbach wrote: >> There is no such property as duplex-full. It's called full-duplex. Leading to >> reduced speed when using the example as base for a real device tree. > > Doh, thanks for correcting this. Would you want to make this a YAML > binding at some point? I can take care of it if you do not have time to > do it. Actually I have started to convert the DSA bindings to YAML, but ran out of time very quickly. Unfortunately the b53 wasn't one of them I've converted already. So, you can go ahead. Thanks, Kurt
diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt index 3bb4e1086913..f1487a751b1a 100644 --- a/Documentation/devicetree/bindings/net/dsa/b53.txt +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt @@ -95,7 +95,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0: fixed-link { speed = <1000>; - duplex-full; + full-duplex; }; }; @@ -129,7 +129,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0: label = "cable-modem"; fixed-link { speed = <1000>; - duplex-full; + full-duplex; }; phy-mode = "rgmii-txid"; }; @@ -139,7 +139,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0: label = "cpu"; fixed-link { speed = <1000>; - duplex-full; + full-duplex; }; phy-mode = "rgmii-txid"; ethernet = <ð0>;
There is no such property as duplex-full. It's called full-duplex. Leading to reduced speed when using the example as base for a real device tree. Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> --- Documentation/devicetree/bindings/net/dsa/b53.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)