[09/13] video: exynos: allow S6E8AX0 to be a module

Message ID 1398274127-2106-9-git-send-email-peter.griffin@linaro.org
State New
Headers show

Commit Message

Peter Griffin April 23, 2014, 5:28 p.m.
From: Arnd Bergmann <arnd@arndb.de>

This driver depends on LCD_CLASS_DEVICE, which can be a
loadable module, but S6E8AX0 can only be built-in at
the moment, which can lead to link errors when the
class device code is not built-in.

Changing this to allow the driver as a module also
requires exporting the exynos_mipi_dsi_register_lcd_driver
symbol.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
---
 drivers/video/fbdev/exynos/Kconfig           |    4 ++--
 drivers/video/fbdev/exynos/exynos_mipi_dsi.c |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Arnd Bergmann April 23, 2014, 6:30 p.m. | #1
On Wednesday 23 April 2014 18:28:43 Peter Griffin wrote:
> 
> diff --git a/drivers/video/fbdev/exynos/Kconfig b/drivers/video/fbdev/exynos/Kconfig
> index fcf2d48..bf776dd 100644
> --- a/drivers/video/fbdev/exynos/Kconfig
> +++ b/drivers/video/fbdev/exynos/Kconfig
> @@ -21,9 +21,9 @@ config EXYNOS_MIPI_DSI
>           This enables support for MIPI-DSI device.
>  
>  config EXYNOS_LCD_S6E8AX0
> -       bool "S6E8AX0 MIPI AMOLED LCD Driver"
> +       tristate "S6E8AX0 MIPI AMOLED LCD Driver"
>         depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
> -       depends on (LCD_CLASS_DEVICE = y)
> +       depends on LCD_CLASS_DEVICE 
>         default n
>         help
>           If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its

Looking at the patch description and the actual changes now, it becomes clear
that the bug was already addressed by Sachin Kamat in 31d6af29066bf "video:
exynos: Fix S6E8AX0 LCD driver build error". You can probably just drop
this patch. I would still prefer my solution, but the change that he did
seems good enough.

	Arnd

Patch

diff --git a/drivers/video/fbdev/exynos/Kconfig b/drivers/video/fbdev/exynos/Kconfig
index fcf2d48..bf776dd 100644
--- a/drivers/video/fbdev/exynos/Kconfig
+++ b/drivers/video/fbdev/exynos/Kconfig
@@ -21,9 +21,9 @@  config EXYNOS_MIPI_DSI
 	  This enables support for MIPI-DSI device.
 
 config EXYNOS_LCD_S6E8AX0
-	bool "S6E8AX0 MIPI AMOLED LCD Driver"
+	tristate "S6E8AX0 MIPI AMOLED LCD Driver"
 	depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
-	depends on (LCD_CLASS_DEVICE = y)
+	depends on LCD_CLASS_DEVICE 
 	default n
 	help
 	  If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
diff --git a/drivers/video/fbdev/exynos/exynos_mipi_dsi.c b/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
index cee9602..cf1390e 100644
--- a/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
+++ b/drivers/video/fbdev/exynos/exynos_mipi_dsi.c
@@ -263,6 +263,7 @@  int exynos_mipi_dsi_register_lcd_driver(struct mipi_dsim_lcd_driver *lcd_drv)
 	return 0;
 
 }
+EXPORT_SYMBOL_GPL(exynos_mipi_dsi_register_lcd_driver);
 
 static struct mipi_dsim_ddi *exynos_mipi_dsi_bind_lcd_ddi(
 						struct mipi_dsim_device *dsim,