[11/13] video/nuc900: allow modular build

Message ID 1398274127-2106-11-git-send-email-peter.griffin@linaro.org
State New
Headers show

Commit Message

Peter Griffin April 23, 2014, 5:28 p.m.
From: Arnd Bergmann <arnd@arndb.de>

The frame buffer core may be a loadable module, and in this
case, the nuc900 driver cannot be built-in. Turning it into
a tristate option lets Kconfig work out the dependency and
avoid broken builds.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnd Bergmann April 23, 2014, 6:33 p.m. | #1
On Wednesday 23 April 2014 18:28:45 Peter Griffin wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The frame buffer core may be a loadable module, and in this
> case, the nuc900 driver cannot be built-in. Turning it into
> a tristate option lets Kconfig work out the dependency and
> avoid broken builds.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org

You should take Wan ZongShun, the nuc900 maintainer on Cc.
Again, this is slightly non-obvious because get_maintainer.pl
doesn't find him because of the move, and because the platform
is called w90x900 in the MAINTAINERS file.

On a side-node, someone should do a patch that fixes up the
MAINTAINERS file to reflect the move of all the drivers/video/*
files to drivers/video/fbdev/*.

	Arnd

Patch

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index e593365..95396de 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2065,7 +2065,7 @@  config FB_S3C2410_DEBUG
 	  through sysfs
 
 config FB_NUC900
-        bool "NUC900 LCD framebuffer support"
+        tristate "NUC900 LCD framebuffer support"
         depends on FB && ARCH_W90X900
         select FB_CFB_FILLRECT
         select FB_CFB_COPYAREA