| Message ID | 1398417452-5395-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | Rejected |
| Headers | show |
On 2014-04-25 13:17, Maxim Uvarov wrote: > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > test/timer/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/timer/Makefile b/test/timer/Makefile > index cefea23..5e5e5c1 100644 > --- a/test/timer/Makefile > +++ b/test/timer/Makefile > @@ -4,7 +4,7 @@ > # SPDX-License-Identifier: BSD-3-Clause > > ODP_ROOT = ../.. > -ODP_APP = odp_timer_test > +ODP_APP = odp_timer Don't think this is a good idea, when we install all the tests, we have to executables with the same name: api_test/odp_timer or timer/odp_timer, one of them will be overwritten when we do make install Cheers, Anders
On 04/25/2014 04:47 PM, Anders Roxell wrote: > On 2014-04-25 13:17, Maxim Uvarov wrote: >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> --- >> test/timer/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/test/timer/Makefile b/test/timer/Makefile >> index cefea23..5e5e5c1 100644 >> --- a/test/timer/Makefile >> +++ b/test/timer/Makefile >> @@ -4,7 +4,7 @@ >> # SPDX-License-Identifier: BSD-3-Clause >> >> ODP_ROOT = ../.. >> -ODP_APP = odp_timer_test >> +ODP_APP = odp_timer > Don't think this is a good idea, when we install all the tests, we have > to executables with the same name: > api_test/odp_timer or timer/odp_timer, one of them willbe overwritten > when we do make install > > Cheers, > Anders We do not have _test prefix anywhere. Also .gitignore has this file without _test prefix. The main propose of this change is not handle this file with git status. BR, Maxim.
diff --git a/test/timer/Makefile b/test/timer/Makefile index cefea23..5e5e5c1 100644 --- a/test/timer/Makefile +++ b/test/timer/Makefile @@ -4,7 +4,7 @@ # SPDX-License-Identifier: BSD-3-Clause ODP_ROOT = ../.. -ODP_APP = odp_timer_test +ODP_APP = odp_timer include $(ODP_ROOT)/Makefile.inc include ../Makefile.inc
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- test/timer/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)