| Message ID | 1603263867-8754-1-git-send-email-bodefang@126.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ASoC: amd: move the call to devm_kzalloc below platform_get_resource() | expand |
On Wed, Oct 21, 2020 at 03:04:27PM +0800, Defang Bo wrote: > Just as the commit <4cb79ef9c6c4>("ASoC: amd: Fix potential NULL pointer dereference"),it makes no sense to allocate any resources if platform_get_resource fails,so move the call to devm_kzalloc() below the mentioned code. As I said on my previous mail: | Please keep your commit message wrapped at below 80 columns. Please don't ignore review comments, people are generally making them for a reason and are likely to have the same concerns if issues remain unaddressed. Having to repeat the same comments can get repetitive and make people question the value of time spent reviewing. If you disagree with the review comments that's fine but you need to reply and discuss your concerns so that the reviewer can understand your decisions. > } > + > adata = devm_kzalloc(&pdev->dev, sizeof(struct i2s_dev_data), GFP_KERNEL); > if (!adata) > return -ENOMEM; > + > adata->acp3x_base = devm_ioremap(&pdev->dev, res->start, This appears to add new whitespace, it doesn't seem to do what the commit log says?
diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c index c9c69eb..04ec603 100644 --- a/sound/soc/amd/raven/acp3x-i2s.c +++ b/sound/soc/amd/raven/acp3x-i2s.c @@ -307,9 +307,11 @@ static int acp3x_dai_probe(struct platform_device *pdev) dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n"); return -ENOMEM; } + adata = devm_kzalloc(&pdev->dev, sizeof(struct i2s_dev_data), GFP_KERNEL); if (!adata) return -ENOMEM; + adata->acp3x_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!adata->acp3x_base)
Just as the commit <4cb79ef9c6c4>("ASoC: amd: Fix potential NULL pointer dereference"),it makes no sense to allocate any resources if platform_get_resource fails,so move the call to devm_kzalloc() below the mentioned code. Signed-off-by: Defang Bo <bodefang@126.com> --- sound/soc/amd/raven/acp3x-i2s.c | 2 ++ 1 file changed, 2 insertions(+)