diff mbox series

bus: mhi: core: Fix null pointer access

Message ID 20201027053310.16469-1-carl.yin@quectel.com
State Superseded
Headers show
Series bus: mhi: core: Fix null pointer access | expand

Commit Message

Carl Yin(殷张成) Oct. 27, 2020, 5:33 a.m. UTC 
From: carl <carl.yin@quectel.com>

function parse_ev_cfg and parse_ch_cfg access mhi_cntrl->mhi_dev
before it is set in function mhi_register_controller,
use cntrl_dev to instead mhi_dev.

Signed-off-by: carl <carl.yin@quectel.com>
---
 drivers/bus/mhi/core/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+linux-arm-msm@kernel.org Dec. 29, 2020, 8:15 p.m. UTC | #1 
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Tue, 27 Oct 2020 13:33:10 +0800 you wrote:
> From: carl <carl.yin@quectel.com>

> 

> function parse_ev_cfg and parse_ch_cfg access mhi_cntrl->mhi_dev

> before it is set in function mhi_register_controller,

> use cntrl_dev to instead mhi_dev.

> 

> Signed-off-by: carl <carl.yin@quectel.com>

> 

> [...]


Here is the summary with links:
  - bus: mhi: core: Fix null pointer access
    https://git.kernel.org/qcom/c/f4d0b39c8425

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index 0ffdebde8..c6b43e90b 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -610,7 +610,7 @@  static int parse_ev_cfg(struct mhi_controller *mhi_cntrl,
 {
 	struct mhi_event *mhi_event;
 	const struct mhi_event_config *event_cfg;
-	struct device *dev = &mhi_cntrl->mhi_dev->dev;
+	struct device *dev = mhi_cntrl->cntrl_dev;
 	int i, num;
 
 	num = config->num_events;
@@ -692,7 +692,7 @@  static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
 			const struct mhi_controller_config *config)
 {
 	const struct mhi_channel_config *ch_cfg;
-	struct device *dev = &mhi_cntrl->mhi_dev->dev;
+	struct device *dev = mhi_cntrl->cntrl_dev;
 	int i;
 	u32 chan;