diff mbox series

[1/5] bus: mhi: core: debugfs: Use correct format specifiers for addresses

Message ID 20200927033652.11789-2-manivannan.sadhasivam@linaro.org
State Superseded
Headers show
Series MHI changes for v5.10 - Take two | expand

Commit Message

Manivannan Sadhasivam Sept. 27, 2020, 3:36 a.m. UTC
For exposing the addresses of read/write pointers and doorbell register,
let's use the correct format specifiers. This fixes the following issues
generated using W=1 build in ARM32 and reported by Kbuild bot:

All warnings (new ones prefixed by >>):

>> drivers/bus/mhi/core/debugfs.c:75:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
                              mhi_event->db_cfg.db_val);
                              ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/bus/mhi/core/debugfs.c:123:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]
                              mhi_chan->db_cfg.db_val);
                              ^~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.

drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_events_show’:
drivers/bus/mhi/core/debugfs.c:74:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   seq_printf(m, " local rp: 0x%llx db: 0x%pad\n", (u64)ring->rp,
                                                   ^
drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_channels_show’:
drivers/bus/mhi/core/debugfs.c:122:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
       (u64)ring->rp, (u64)ring->wp,
       ^
drivers/bus/mhi/core/debugfs.c:122:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
       (u64)ring->rp, (u64)ring->wp,
                      ^
drivers/bus/mhi/core/debugfs.c:121:62: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t {aka unsigned int}’ [-Wformat=]
   seq_printf(m, " local rp: 0x%llx local wp: 0x%llx db: 0x%llx\n",
                                                           ~~~^
                                                           %x
drivers/bus/mhi/core/debugfs.c:123:7:
       mhi_chan->db_cfg.db_val);

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/core/debugfs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Greg KH Sept. 27, 2020, 10:20 a.m. UTC | #1
On Sun, Sep 27, 2020 at 09:06:48AM +0530, Manivannan Sadhasivam wrote:
> For exposing the addresses of read/write pointers and doorbell register,

> let's use the correct format specifiers. This fixes the following issues

> generated using W=1 build in ARM32 and reported by Kbuild bot:

> 

> All warnings (new ones prefixed by >>):

> 

> >> drivers/bus/mhi/core/debugfs.c:75:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]

>                               mhi_event->db_cfg.db_val);

>                               ^~~~~~~~~~~~~~~~~~~~~~~~

>    drivers/bus/mhi/core/debugfs.c:123:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]

>                               mhi_chan->db_cfg.db_val);

>                               ^~~~~~~~~~~~~~~~~~~~~~~

>    2 warnings generated.

> 

> drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_events_show’:

> drivers/bus/mhi/core/debugfs.c:74:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

>    seq_printf(m, " local rp: 0x%llx db: 0x%pad\n", (u64)ring->rp,

>                                                    ^

> drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_channels_show’:

> drivers/bus/mhi/core/debugfs.c:122:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

>        (u64)ring->rp, (u64)ring->wp,

>        ^

> drivers/bus/mhi/core/debugfs.c:122:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

>        (u64)ring->rp, (u64)ring->wp,

>                       ^

> drivers/bus/mhi/core/debugfs.c:121:62: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t {aka unsigned int}’ [-Wformat=]

>    seq_printf(m, " local rp: 0x%llx local wp: 0x%llx db: 0x%llx\n",

>                                                            ~~~^

>                                                            %x

> drivers/bus/mhi/core/debugfs.c:123:7:

>        mhi_chan->db_cfg.db_val);

> 

> Reported-by: kernel test robot <lkp@intel.com>

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  drivers/bus/mhi/core/debugfs.c | 10 +++++-----

>  1 file changed, 5 insertions(+), 5 deletions(-)


This file is not in any of the branches of any of my trees.

What was it made against?

confused,

greg k-h
Greg KH Sept. 27, 2020, 10:23 a.m. UTC | #2
On Sun, Sep 27, 2020 at 09:06:48AM +0530, Manivannan Sadhasivam wrote:
> For exposing the addresses of read/write pointers and doorbell register,

> let's use the correct format specifiers. This fixes the following issues

> generated using W=1 build in ARM32 and reported by Kbuild bot:

> 

> All warnings (new ones prefixed by >>):

> 

> >> drivers/bus/mhi/core/debugfs.c:75:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]

>                               mhi_event->db_cfg.db_val);

>                               ^~~~~~~~~~~~~~~~~~~~~~~~

>    drivers/bus/mhi/core/debugfs.c:123:7: warning: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Wformat]

>                               mhi_chan->db_cfg.db_val);

>                               ^~~~~~~~~~~~~~~~~~~~~~~

>    2 warnings generated.

> 

> drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_events_show’:

> drivers/bus/mhi/core/debugfs.c:74:51: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

>    seq_printf(m, " local rp: 0x%llx db: 0x%pad\n", (u64)ring->rp,

>                                                    ^

> drivers/bus/mhi/core/debugfs.c: In function ‘mhi_debugfs_channels_show’:

> drivers/bus/mhi/core/debugfs.c:122:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

>        (u64)ring->rp, (u64)ring->wp,

>        ^

> drivers/bus/mhi/core/debugfs.c:122:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

>        (u64)ring->rp, (u64)ring->wp,

>                       ^

> drivers/bus/mhi/core/debugfs.c:121:62: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t {aka unsigned int}’ [-Wformat=]

>    seq_printf(m, " local rp: 0x%llx local wp: 0x%llx db: 0x%llx\n",

>                                                            ~~~^

>                                                            %x

> drivers/bus/mhi/core/debugfs.c:123:7:

>        mhi_chan->db_cfg.db_val);

> 

> Reported-by: kernel test robot <lkp@intel.com>

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  drivers/bus/mhi/core/debugfs.c | 10 +++++-----

>  1 file changed, 5 insertions(+), 5 deletions(-)


Ah, this is against your first set of patches, that's the confusion on
my part.

Please just fix them all up and resend 1 series of patches, that isn't
broken, and I will be glad to review and take that.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/bus/mhi/core/debugfs.c b/drivers/bus/mhi/core/debugfs.c
index 53d05a8e168d..f50d73054db4 100644
--- a/drivers/bus/mhi/core/debugfs.c
+++ b/drivers/bus/mhi/core/debugfs.c
@@ -71,8 +71,8 @@  static int mhi_debugfs_events_show(struct seq_file *m, void *d)
 		seq_printf(m, " rp: 0x%llx wp: 0x%llx", er_ctxt->rp,
 			   er_ctxt->wp);
 
-		seq_printf(m, " local rp: 0x%llx db: 0x%llx\n", (u64)ring->rp,
-			   mhi_event->db_cfg.db_val);
+		seq_printf(m, " local rp: 0x%pK db: 0x%pad\n", ring->rp,
+			   &mhi_event->db_cfg.db_val);
 	}
 
 	return 0;
@@ -118,9 +118,9 @@  static int mhi_debugfs_channels_show(struct seq_file *m, void *d)
 		seq_printf(m, " base: 0x%llx len: 0x%llx wp: 0x%llx",
 			   chan_ctxt->rbase, chan_ctxt->rlen, chan_ctxt->wp);
 
-		seq_printf(m, " local rp: 0x%llx local wp: 0x%llx db: 0x%llx\n",
-			   (u64)ring->rp, (u64)ring->wp,
-			   mhi_chan->db_cfg.db_val);
+		seq_printf(m, " local rp: 0x%pK local wp: 0x%pK db: 0x%pad\n",
+			   ring->rp, ring->wp,
+			   &mhi_chan->db_cfg.db_val);
 	}
 
 	return 0;