| Message ID | 20200930225046.173190-3-Jason@zx2c4.com |
|---|---|
| State | New |
| Headers | show |
| Series | Support trackpoint and touchpad in Thinkpad P1 gen 2 / X1E gen 2 | expand |
On Thu, Oct 01, 2020 at 12:50:46AM +0200, Jason A. Donenfeld wrote: > With the new RMI4 F3A support, we're now able to enable full RMI4 > support for this model. We also tidy up the comments a bit, as the X1E > is essentially the same computer as the P1. > > Acked-by: Lyude Paul <lyude@redhat.com> > Cc: Vincent Huang <vincent.huang@tw.synaptics.com> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > --- > drivers/input/mouse/synaptics.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 8a54efd6eb95..bf0f3fdf10d9 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -179,7 +179,8 @@ static const char * const smbus_pnp_ids[] = { > "LEN0093", /* T480 */ > "LEN0096", /* X280 */ > "LEN0097", /* X280 -> ALPS trackpoint */ > - "LEN0099", /* X1 Extreme 1st */ > + "LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */ > + "LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */ Moved this entry one down to keep the list sorted, and applied, thank you. -- Dmitry
Oddly, CPU usage seems exceedingly high when using the trackpoint, in the rmi4 irq handler. Running perf-top indicates a hotspot in i801_access calling "in (%dx),%al", which makes sense. I wonder: is this a culprit of expensive accesses in general, which Sultan (CC'd) has been working on? Or are we hitting something different here? Improper IRQ masking in the i801 code? Jason
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 8a54efd6eb95..bf0f3fdf10d9 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -179,7 +179,8 @@ static const char * const smbus_pnp_ids[] = { "LEN0093", /* T480 */ "LEN0096", /* X280 */ "LEN0097", /* X280 -> ALPS trackpoint */ - "LEN0099", /* X1 Extreme 1st */ + "LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */ + "LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */ "LEN009b", /* T580 */ "LEN200f", /* T450s */ "LEN2044", /* L470 */