diff mbox series

HID: alps: clean up indentation issue

Message ID 20200920141716.32919-1-colin.king@canonical.com
State Accepted
Commit 2c3468893779480f90b4a7a8e3df0ade0c4b7a75
Headers show
Series HID: alps: clean up indentation issue | expand

Commit Message

Colin King Sept. 20, 2020, 2:17 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

There is an if statement that is indented too deeply, fix
this by removing the extraneous tab.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/hid/hid-alps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Kosina Sept. 22, 2020, 9:20 a.m. UTC | #1
On Sun, 20 Sep 2020, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>

> 

> There is an if statement that is indented too deeply, fix

> this by removing the extraneous tab.

> 

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

> ---

>  drivers/hid/hid-alps.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c

> index a9c2de95c5e2..3feaece13ade 100644

> --- a/drivers/hid/hid-alps.c

> +++ b/drivers/hid/hid-alps.c

> @@ -526,7 +526,7 @@ static int u1_init(struct hid_device *hdev, struct alps_dev *pri_data)

>  

>  	ret = u1_read_write_register(hdev, ADDRESS_U1_NUM_SENS_Y,

>  			&sen_line_num_y, 0, true);

> -		if (ret < 0) {

> +	if (ret < 0) {

>  		dev_err(&hdev->dev, "failed U1_NUM_SENS_Y (%d)\n", ret);


I am usually not taking whitespace fixes, but this one actually really 
does improve code readability, so I am taking this one. Thanks,

-- 
Jiri Kosina
SUSE Labs
diff mbox series

Patch

diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index a9c2de95c5e2..3feaece13ade 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -526,7 +526,7 @@  static int u1_init(struct hid_device *hdev, struct alps_dev *pri_data)
 
 	ret = u1_read_write_register(hdev, ADDRESS_U1_NUM_SENS_Y,
 			&sen_line_num_y, 0, true);
-		if (ret < 0) {
+	if (ret < 0) {
 		dev_err(&hdev->dev, "failed U1_NUM_SENS_Y (%d)\n", ret);
 		goto exit;
 	}