| Message ID | 20201026144943.30821-1-grzegorz.jaszczyk@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | soc: ti: pruss: Remove wrong check against *get_match_data return value | expand |
Hi Greg, On 10/26/20 9:49 AM, Grzegorz Jaszczyk wrote: > Since the of_device_get_match_data() doesn't return error code, remove > wrong IS_ERR test. Proper check against NULL pointer is already done > later before usage: if (data && data->...). > > Additionally, proceeding with empty device data is valid (e.g. in case > of "ti,am3356-pruss"). > > Reported-by: Wei Yongjun <weiyongjun1@huawei.com> Please add the appropriate Fixes: tag. And prefer %s/Remove/Fix/ in patch title. With that, Acked-by: Suman Anna <s-anna@ti.com> regards Suman > Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> > --- > drivers/soc/ti/pruss.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index cc0b4ad7a3d3..5d6e7132a5c4 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -126,8 +126,6 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node) > int ret = 0; > > data = of_device_get_match_data(dev); > - if (IS_ERR(data)) > - return -ENODEV; > > clks_np = of_get_child_by_name(cfg_node, "clocks"); > if (!clks_np) { > @@ -175,10 +173,6 @@ static int pruss_probe(struct platform_device *pdev) > const char *mem_names[PRUSS_MEM_MAX] = { "dram0", "dram1", "shrdram2" }; > > data = of_device_get_match_data(&pdev->dev); > - if (IS_ERR(data)) { > - dev_err(dev, "missing private data\n"); > - return -ENODEV; > - } > > ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); > if (ret) { >
Hi Suman, On Tue, 10 Nov 2020 at 21:43, Suman Anna <s-anna@ti.com> wrote: > > Hi Greg, > > On 10/26/20 9:49 AM, Grzegorz Jaszczyk wrote: > > Since the of_device_get_match_data() doesn't return error code, remove > > wrong IS_ERR test. Proper check against NULL pointer is already done > > later before usage: if (data && data->...). > > > > Additionally, proceeding with empty device data is valid (e.g. in case > > of "ti,am3356-pruss"). > > > > Reported-by: Wei Yongjun <weiyongjun1@huawei.com> > > Please add the appropriate Fixes: tag. > > And prefer %s/Remove/Fix/ in patch title. Sure. > > With that, > Acked-by: Suman Anna <s-anna@ti.com> Thank you, I will post v2 with all improvements soon. Best regards, Grzegorz
diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c index cc0b4ad7a3d3..5d6e7132a5c4 100644 --- a/drivers/soc/ti/pruss.c +++ b/drivers/soc/ti/pruss.c @@ -126,8 +126,6 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node) int ret = 0; data = of_device_get_match_data(dev); - if (IS_ERR(data)) - return -ENODEV; clks_np = of_get_child_by_name(cfg_node, "clocks"); if (!clks_np) { @@ -175,10 +173,6 @@ static int pruss_probe(struct platform_device *pdev) const char *mem_names[PRUSS_MEM_MAX] = { "dram0", "dram1", "shrdram2" }; data = of_device_get_match_data(&pdev->dev); - if (IS_ERR(data)) { - dev_err(dev, "missing private data\n"); - return -ENODEV; - } ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); if (ret) {
Since the of_device_get_match_data() doesn't return error code, remove wrong IS_ERR test. Proper check against NULL pointer is already done later before usage: if (data && data->...). Additionally, proceeding with empty device data is valid (e.g. in case of "ti,am3356-pruss"). Reported-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> --- drivers/soc/ti/pruss.c | 6 ------ 1 file changed, 6 deletions(-)