| Message ID | 1399283686-6127-6-git-send-email-rogerq@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Roger, On Mon, 5 May 2014, Roger Quadros wrote: > Add the sysconfig class bits for the Super Speed USB > controllers > > CC: Paul Walmsley <paul@pwsan.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> As with the previous DRA7 hwmod patch, I'd like to get a Reviewed-by: and a Tested-by: before merging this one. - Paul -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
+ Nishant and Rajendra for review. On 05/05/2014 12:54 PM, Roger Quadros wrote: > Add the sysconfig class bits for the Super Speed USB > controllers > > CC: Paul Walmsley <paul@pwsan.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > index 810c205..067d322 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > @@ -1731,8 +1731,20 @@ static struct omap_hwmod dra7xx_uart6_hwmod = { > * > */ > > +static struct omap_hwmod_class_sysconfig dra7xx_usb_otg_ss_sysc = { > + .rev_offs = 0x0000, > + .sysc_offs = 0x0010, > + .sysc_flags = (SYSC_HAS_DMADISABLE | SYSC_HAS_MIDLEMODE | > + SYSC_HAS_SIDLEMODE), > + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | > + SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | > + MSTANDBY_SMART | MSTANDBY_SMART_WKUP), > + .sysc_fields = &omap_hwmod_sysc_type2, > +}; > + > static struct omap_hwmod_class dra7xx_usb_otg_ss_hwmod_class = { > .name = "usb_otg_ss", > + .sysc = &dra7xx_usb_otg_ss_sysc, > }; > > /* usb_otg_ss1 */ > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 18 June 2014 04:40 PM, Roger Quadros wrote: > + Nishant and Rajendra for review. > > On 05/05/2014 12:54 PM, Roger Quadros wrote: >> Add the sysconfig class bits for the Super Speed USB >> controllers >> >> CC: Paul Walmsley <paul@pwsan.com> >> Signed-off-by: Roger Quadros <rogerq@ti.com> verified against TRM version vP, looks good to me. Reviewed-by: Rajendra Nayak <rnayak@ti.com> >> --- >> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> index 810c205..067d322 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> @@ -1731,8 +1731,20 @@ static struct omap_hwmod dra7xx_uart6_hwmod = { >> * >> */ >> >> +static struct omap_hwmod_class_sysconfig dra7xx_usb_otg_ss_sysc = { >> + .rev_offs = 0x0000, >> + .sysc_offs = 0x0010, >> + .sysc_flags = (SYSC_HAS_DMADISABLE | SYSC_HAS_MIDLEMODE | >> + SYSC_HAS_SIDLEMODE), >> + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | >> + SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | >> + MSTANDBY_SMART | MSTANDBY_SMART_WKUP), >> + .sysc_fields = &omap_hwmod_sysc_type2, >> +}; >> + >> static struct omap_hwmod_class dra7xx_usb_otg_ss_hwmod_class = { >> .name = "usb_otg_ss", >> + .sysc = &dra7xx_usb_otg_ss_sysc, >> }; >> >> /* usb_otg_ss1 */ >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/18/2014 02:19 PM, Rajendra Nayak wrote: > On Wednesday 18 June 2014 04:40 PM, Roger Quadros wrote: >> + Nishant and Rajendra for review. >> >> On 05/05/2014 12:54 PM, Roger Quadros wrote: >>> Add the sysconfig class bits for the Super Speed USB >>> controllers >>> >>> CC: Paul Walmsley <paul@pwsan.com> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> > > verified against TRM version vP, looks good to me. > Reviewed-by: Rajendra Nayak <rnayak@ti.com> Tested-by: Roger Quadros <rogerq@ti.com> against 3.16-rc1. no dependency patches. cheers, -roger > >>> --- >>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>> index 810c205..067d322 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>> @@ -1731,8 +1731,20 @@ static struct omap_hwmod dra7xx_uart6_hwmod = { >>> * >>> */ >>> >>> +static struct omap_hwmod_class_sysconfig dra7xx_usb_otg_ss_sysc = { >>> + .rev_offs = 0x0000, >>> + .sysc_offs = 0x0010, >>> + .sysc_flags = (SYSC_HAS_DMADISABLE | SYSC_HAS_MIDLEMODE | >>> + SYSC_HAS_SIDLEMODE), >>> + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | >>> + SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | >>> + MSTANDBY_SMART | MSTANDBY_SMART_WKUP), >>> + .sysc_fields = &omap_hwmod_sysc_type2, >>> +}; >>> + >>> static struct omap_hwmod_class dra7xx_usb_otg_ss_hwmod_class = { >>> .name = "usb_otg_ss", >>> + .sysc = &dra7xx_usb_otg_ss_sysc, >>> }; >>> >>> /* usb_otg_ss1 */ >>> >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sekhar, On 06/18/2014 02:19 PM, Rajendra Nayak wrote: > On Wednesday 18 June 2014 04:40 PM, Roger Quadros wrote: >> + Nishant and Rajendra for review. >> >> On 05/05/2014 12:54 PM, Roger Quadros wrote: >>> Add the sysconfig class bits for the Super Speed USB >>> controllers >>> >>> CC: Paul Walmsley <paul@pwsan.com> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> > > verified against TRM version vP, looks good to me. > Reviewed-by: Rajendra Nayak <rnayak@ti.com> Could you please give your Tested-by tag for this? Then we can take this into 3.16-rc. Thanks. cheers, -roger > >>> --- >>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>> index 810c205..067d322 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >>> @@ -1731,8 +1731,20 @@ static struct omap_hwmod dra7xx_uart6_hwmod = { >>> * >>> */ >>> >>> +static struct omap_hwmod_class_sysconfig dra7xx_usb_otg_ss_sysc = { >>> + .rev_offs = 0x0000, >>> + .sysc_offs = 0x0010, >>> + .sysc_flags = (SYSC_HAS_DMADISABLE | SYSC_HAS_MIDLEMODE | >>> + SYSC_HAS_SIDLEMODE), >>> + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | >>> + SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | >>> + MSTANDBY_SMART | MSTANDBY_SMART_WKUP), >>> + .sysc_fields = &omap_hwmod_sysc_type2, >>> +}; >>> + >>> static struct omap_hwmod_class dra7xx_usb_otg_ss_hwmod_class = { >>> .name = "usb_otg_ss", >>> + .sysc = &dra7xx_usb_otg_ss_sysc, >>> }; >>> >>> /* usb_otg_ss1 */ >>> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 02 July 2014 04:56 PM, Roger Quadros wrote: > Sekhar, > > On 06/18/2014 02:19 PM, Rajendra Nayak wrote: >> On Wednesday 18 June 2014 04:40 PM, Roger Quadros wrote: >>> + Nishant and Rajendra for review. >>> >>> On 05/05/2014 12:54 PM, Roger Quadros wrote: >>>> Add the sysconfig class bits for the Super Speed USB >>>> controllers >>>> >>>> CC: Paul Walmsley <paul@pwsan.com> >>>> Signed-off-by: Roger Quadros <rogerq@ti.com> >> >> verified against TRM version vP, looks good to me. >> Reviewed-by: Rajendra Nayak <rnayak@ti.com> > > Could you please give your Tested-by tag for this? Then we can take this into 3.16-rc. Boot tested on my DRA7x EVM. Boot log here: http://paste.ubuntu.com/7741337/ Tested-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c index 810c205..067d322 100644 --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c @@ -1731,8 +1731,20 @@ static struct omap_hwmod dra7xx_uart6_hwmod = { * */ +static struct omap_hwmod_class_sysconfig dra7xx_usb_otg_ss_sysc = { + .rev_offs = 0x0000, + .sysc_offs = 0x0010, + .sysc_flags = (SYSC_HAS_DMADISABLE | SYSC_HAS_MIDLEMODE | + SYSC_HAS_SIDLEMODE), + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | + SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | + MSTANDBY_SMART | MSTANDBY_SMART_WKUP), + .sysc_fields = &omap_hwmod_sysc_type2, +}; + static struct omap_hwmod_class dra7xx_usb_otg_ss_hwmod_class = { .name = "usb_otg_ss", + .sysc = &dra7xx_usb_otg_ss_sysc, }; /* usb_otg_ss1 */
Add the sysconfig class bits for the Super Speed USB controllers CC: Paul Walmsley <paul@pwsan.com> Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)