diff mbox series

scsi: aacraid: move declaration of 'aac_sync_mode' to aacraid.h

Message ID 20200921142707.874888-1-yanaijie@huawei.com
State New
Headers show
Series scsi: aacraid: move declaration of 'aac_sync_mode' to aacraid.h | expand

Commit Message

Jason Yan Sept. 21, 2020, 2:27 p.m. UTC
This addresses the following sparse warning:

drivers/scsi/aacraid/aachba.c:244:5: warning: symbol 'aac_sync_mode' was
not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/aacraid/aacraid.h  | 1 +
 drivers/scsi/aacraid/comminit.c | 1 -
 drivers/scsi/aacraid/linit.c    | 1 -
 drivers/scsi/aacraid/src.c      | 1 -
 4 files changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index e3e4ecbea726..31aa752c39dd 100644
--- a/drivers/scsi/aacraid/aacraid.h
+++ b/drivers/scsi/aacraid/aacraid.h
@@ -2769,4 +2769,5 @@  extern int update_interval;
 extern int check_interval;
 extern int aac_check_reset;
 extern int aac_fib_dump;
+extern int aac_sync_mode;
 #endif
diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
index 355b16f0b145..e627271b3f15 100644
--- a/drivers/scsi/aacraid/comminit.c
+++ b/drivers/scsi/aacraid/comminit.c
@@ -511,7 +511,6 @@  struct aac_dev *aac_init_adapter(struct aac_dev *dev)
 {
 	u32 status[5];
 	struct Scsi_Host * host = dev->scsi_host_ptr;
-	extern int aac_sync_mode;
 
 	/*
 	 *	Check the preferred comm settings, defaults from template.
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 8f3772480582..d820995a826f 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -1636,7 +1636,6 @@  static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	int unique_id = 0;
 	u64 dmamask;
 	int mask_bits = 0;
-	extern int aac_sync_mode;
 
 	/*
 	 * Only series 7 needs freset.
diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 11ef58204e96..a63976deab4f 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -78,7 +78,6 @@  static irqreturn_t aac_src_intr_message(int irq, void *dev_id)
 		unsigned long sflags;
 		struct list_head *entry;
 		int send_it = 0;
-		extern int aac_sync_mode;
 
 		if (!aac_sync_mode && !dev->msi_enabled) {
 			src_writel(dev, MUnit.ODR_C, bellbits);