diff mbox

[Xen-devel,osstest,v5] Add libvirt build and test jobs.

Message ID 1399363972.3014.0.camel@kazak.uk.xensource.com
State New
Headers show

Commit Message

Ian Campbell May 6, 2014, 8:12 a.m. UTC 
On Fri, 2014-05-02 at 17:24 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH osstest v5] Add libvirt build and test jobs."):
> > Looking at some other stuff, I think I needn't have done any of this
> > treevcs stuff:
> > 
> > [...]
> > > +: ${TREEVCS_LIBVIRT:=git}
> > [...]
> > > +: ${TREEVCS_GNULIB_LIBVIRT:=git}
> > [...]
> > > +                ${TREEVCS_LIBVIRT:+treevcs_libvirt=}${TREEVCS_LIBVIRT}       \
> > [...]
> 
> Yes, I don't think it's really necessary.  Easier just to fold this
> into the urls etc.

Not sure what you mean by "fold into the URLS", it is already present
there and things seem to be inferred correctly. So I think the relevant
cleanup is to just nuke all of this.

8<----------------------

From fa701736e100572814944c441f3c66c4643365fe Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Tue, 6 May 2014 09:05:23 +0100
Subject: [PATCH] Drop unnecessary TREEVCS settings for libvirt and
 gnulib-libvirt

This will be correctly inferred from the URL.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 ap-common  | 2 --
 mfi-common | 2 --
 2 files changed, 4 deletions(-)

Comments

Ian Jackson May 12, 2014, 11:03 a.m. UTC | #1 
Ian Campbell writes ("Re: [PATCH osstest v5] Add libvirt build and test jobs."):
> On Fri, 2014-05-02 at 17:24 +0100, Ian Jackson wrote:
> > Yes, I don't think it's really necessary.  Easier just to fold this
> > into the urls etc.
> 
> Not sure what you mean by "fold into the URLS", it is already present
> there and things seem to be inferred correctly. So I think the relevant
> cleanup is to just nuke all of this.

I think that's what I meant, yes.

> From: Ian Campbell <ian.campbell@citrix.com>
> Date: Tue, 6 May 2014 09:05:23 +0100
> Subject: [PATCH] Drop unnecessary TREEVCS settings for libvirt and
>  gnulib-libvirt
> 
> This will be correctly inferred from the URL.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

and queued up.

Ian.
diff mbox

Patch

diff --git a/ap-common b/ap-common
index 4cae650..ed37811 100644
--- a/ap-common
+++ b/ap-common
@@ -36,10 +36,8 @@ 
 : ${TREE_LIBVIRT:=git://libvirt.org/libvirt.git}
 : ${PUSH_TREE_LIBVIRT:=$XENBITS:/home/xen/git/libvirt.git}
 : ${BASE_TREE_LIBVIRT:=git://xenbits.xen.org/libvirt.git}
-: ${TREEVCS_LIBVIRT:=git}
 
 : ${TREE_GNULIB_LIBVIRT:=git://git.sv.gnu.org/gnulib.git}
-: ${TREEVCS_GNULIB_LIBVIRT:=git}
 
 : ${TREE_LINUXFIRMWARE:=git://xenbits.xen.org/osstest/linux-firmware.git}
 : ${PUSH_TREE_LINUXFIRMWARE:=$XENBITS:/home/osstest/ext/linux-firmware.git}
diff --git a/mfi-common b/mfi-common
index 1663c96..464001a 100644
--- a/mfi-common
+++ b/mfi-common
@@ -170,9 +170,7 @@  create_build_jobs () {
                 host_hostflags=$build_hostflags                              \
                 buildjob=${bfi}build-$arch                                   \
                 tree_libvirt=$TREE_LIBVIRT revision_libvirt=$REVISION_LIBVIRT\
-                ${TREEVCS_LIBVIRT:+treevcs_libvirt=}${TREEVCS_LIBVIRT}       \
                 tree_gnulib_libvirt=$TREE_GNULIB_LIBVIRT revision_gnulib_libvirt=$REVISION_GNULIB_LIBVIRT\
-                ${TREEVCS_GNULIB_LIBVIRT:+treevcs_gnulib_libvirt=}${TREEVCS_GNULIB_LIBVIRT}
 
     case "$arch" in
     armhf) continue;; # don't do any other kernel builds