| Message ID | 20201022014411.2343-1-peter.chen@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/6] usb: cdns3: host: add .suspend_quirk for xhci-plat.c | expand |
On Thu, Oct 22, 2020 at 09:44:11AM +0800, Peter Chen wrote: > To support low power mode for controller, the driver needs wakeup-irq > to reflect the signal changing after controller is stopped, and waking > the controller up accordingly. > > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > index ac20b98e9910..0171e64ef95e 100644 > --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > @@ -30,12 +30,15 @@ properties: > - description: OTG/DRD controller interrupt > - description: XHCI host controller interrupt > - description: Device controller interrupt > + - description: interrupt used to wake up core, eg: when usbcmd.rs is > + cleared by xhci core, this interrupt is optional. You need 'minItems: 3' here and below to make this optional. I guess we don't have an example for this binding or it would fail. > > interrupt-names: > items: > - const: host > - const: peripheral > - const: otg > + - const: wakeup > > dr_mode: > enum: [host, otg, peripheral] > -- > 2.17.1 >
> > @@ -30,12 +30,15 @@ properties: > > - description: OTG/DRD controller interrupt > > - description: XHCI host controller interrupt > > - description: Device controller interrupt > > + - description: interrupt used to wake up core, eg: when usbcmd.rs is > > + cleared by xhci core, this interrupt is optional. > > You need 'minItems: 3' here and below to make this optional. I guess we don't > have an example for this binding or it would fail. > Updated, and sent v2. Yes, we don't need it for example, the probe will not fail even this property is not there. Peter > > > > interrupt-names: > > items: > > - const: host > > - const: peripheral > > - const: otg > > + - const: wakeup > > > > dr_mode: > > enum: [host, otg, peripheral] > > -- > > 2.17.1 > >
diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml index ac20b98e9910..0171e64ef95e 100644 --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml @@ -30,12 +30,15 @@ properties: - description: OTG/DRD controller interrupt - description: XHCI host controller interrupt - description: Device controller interrupt + - description: interrupt used to wake up core, eg: when usbcmd.rs is + cleared by xhci core, this interrupt is optional. interrupt-names: items: - const: host - const: peripheral - const: otg + - const: wakeup dr_mode: enum: [host, otg, peripheral]
To support low power mode for controller, the driver needs wakeup-irq to reflect the signal changing after controller is stopped, and waking the controller up accordingly. Signed-off-by: Peter Chen <peter.chen@nxp.com> --- Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++ 1 file changed, 3 insertions(+)