diff mbox series

[v3,1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

Message ID 20201016094155.532088-1-fido_max@inbox.ru
State Superseded
Headers show
Series [v3,1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes | expand

Commit Message

Maxim Kochetkov Oct. 16, 2020, 9:41 a.m. UTC 
The VSC9953 Seville switch has 2 megabits of buffer split into 4360
words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
2 megabits is (2048 / 8) * 1024 = 256 * 1024.

Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
---
 drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vladimir Oltean Oct. 16, 2020, 8:18 p.m. UTC | #1 
On Fri, Oct 16, 2020 at 12:41:55PM +0300, Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360

> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.

> 2 megabits is (2048 / 8) * 1024 = 256 * 1024.

> 

> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>

> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

> Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")

> ---


Maxim, networking maintainers apply patches on the master branch of one
of the 2 trees:
- https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git if
  it's a new feature
- https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git if it's
  a bug fix

Your patch applies to neither of these trees.
diff mbox series

Patch

diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c
index 9e9fd19e1d00..e2cd49eec037 100644
--- a/drivers/net/dsa/ocelot/seville_vsc9953.c
+++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
@@ -1010,7 +1010,7 @@  static const struct felix_info seville_info_vsc9953 = {
 	.vcap_is2_keys		= vsc9953_vcap_is2_keys,
 	.vcap_is2_actions	= vsc9953_vcap_is2_actions,
 	.vcap			= vsc9953_vcap_props,
-	.shared_queue_sz	= 2048 * 1024,
+	.shared_queue_sz	= 256 * 1024,
 	.num_mact_rows		= 2048,
 	.num_ports		= 10,
 	.mdio_bus_alloc		= vsc9953_mdio_bus_alloc,