diff mbox

[3/3] ARM: sti: stih41x: Provide a proper header for this DTSI file

Message ID 1400660415-14720-3-git-send-email-lee.jones@linaro.org
State New
Headers show

Commit Message

Lee Jones May 21, 2014, 8:20 a.m. UTC
Also explicitly include STiH416 Clk bindings instead of relying on
inheriting them from other DTSI files which we happen to include.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/stih41x.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Maxime COQUELIN May 21, 2014, 8:32 a.m. UTC | #1
Hi Lee,

On 05/21/2014 10:20 AM, Lee Jones wrote:
> Also explicitly include STiH416 Clk bindings instead of relying on
> inheriting them from other DTSI files which we happen to include.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>   arch/arm/boot/dts/stih41x.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih41x.dtsi b/arch/arm/boot/dts/stih41x.dtsi
> index f5b9898..32730e5 100644
> --- a/arch/arm/boot/dts/stih41x.dtsi
> +++ b/arch/arm/boot/dts/stih41x.dtsi
> @@ -1,3 +1,11 @@
> +/*
> + * Copyright (C) 2014 STMicroelectronics Limited.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * publishhed by the Free Software Foundation.
> + */
> +#include "stih416-clock.dtsi"

Nack.
As discussed on IRC, this dtsi file is included by stih415.dtsi.
In this case, we want to include stih415-clocks.dtsi instead.

Regards,
Maxime
>   / {
>   	#address-cells = <1>;
>   	#size-cells = <1>;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Lee Jones May 21, 2014, 9:12 a.m. UTC | #2
> >Also explicitly include STiH416 Clk bindings instead of relying on
> >inheriting them from other DTSI files which we happen to include.
> >
> >Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >---
> >  arch/arm/boot/dts/stih41x.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/stih41x.dtsi b/arch/arm/boot/dts/stih41x.dtsi
> >index f5b9898..32730e5 100644
> >--- a/arch/arm/boot/dts/stih41x.dtsi
> >+++ b/arch/arm/boot/dts/stih41x.dtsi
> >@@ -1,3 +1,11 @@
> >+/*
> >+ * Copyright (C) 2014 STMicroelectronics Limited.
> >+ *
> >+ * This program is free software; you can redistribute it and/or modify
> >+ * it under the terms of the GNU General Public License version 2 as
> >+ * publishhed by the Free Software Foundation.
> >+ */
> >+#include "stih416-clock.dtsi"
> 
> Nack.
> As discussed on IRC, this dtsi file is included by stih415.dtsi.
> In this case, we want to include stih415-clocks.dtsi instead.

+1 resubmitted.

> >  / {
> >  	#address-cells = <1>;
> >  	#size-cells = <1>;
> >
diff mbox

Patch

diff --git a/arch/arm/boot/dts/stih41x.dtsi b/arch/arm/boot/dts/stih41x.dtsi
index f5b9898..32730e5 100644
--- a/arch/arm/boot/dts/stih41x.dtsi
+++ b/arch/arm/boot/dts/stih41x.dtsi
@@ -1,3 +1,11 @@ 
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+#include "stih416-clock.dtsi"
 / {
 	#address-cells = <1>;
 	#size-cells = <1>;