| Message ID | 20200915154232.27523-1-sibis@codeaurora.org |
|---|---|
| State | New |
| Headers | show |
| Series | soc: qcom: apr: Fixup the error displayed on lookup failure | expand |
On Tue, Sep 15, 2020 at 09:12:32PM +0530, Sibi Sankar wrote: > APR client incorrectly prints out "ret" variable on pdr_add_lookup failure, > it should be printing the error value returned by the lookup instead. > > Fixes: 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality") > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > drivers/soc/qcom/apr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c > index 1f35b097c6356..7abfc8c4fdc72 100644 > --- a/drivers/soc/qcom/apr.c > +++ b/drivers/soc/qcom/apr.c > @@ -328,7 +328,7 @@ static int of_apr_add_pd_lookups(struct device *dev) > > pds = pdr_add_lookup(apr->pdr, service_name, service_path); > if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) { > - dev_err(dev, "pdr add lookup failed: %d\n", ret); > + dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds)); > return PTR_ERR(pds); > } > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>
diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index 1f35b097c6356..7abfc8c4fdc72 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -328,7 +328,7 @@ static int of_apr_add_pd_lookups(struct device *dev) pds = pdr_add_lookup(apr->pdr, service_name, service_path); if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) { - dev_err(dev, "pdr add lookup failed: %d\n", ret); + dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds)); return PTR_ERR(pds); } }
APR client incorrectly prints out "ret" variable on pdr_add_lookup failure, it should be printing the error value returned by the lookup instead. Fixes: 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality") Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- drivers/soc/qcom/apr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)