| Message ID | 1401262770-25343-3-git-send-email-tomasz.nowicki@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 28.05.14 09:39:27, Tomasz Nowicki wrote: > +config ACPI_APEI_NMI > + bool "NMI error notification support" > + default y > + depends on ACPI_APEI_GHES && X86 > + help > + Firmware first mode can use NMI notification mechanism to report errors > + to operating system. This feature is currently supported by X86 > + architecture only. > + This selection is not necessary. I don't see why one should select this at all. It's either there for an arch or not. Just use ARCH_HAS_ style and and hard select ARCH_HAS_ACPI_APEI_NMI for x86. There is no need for the ACPI_APEI_GHES dependency then. -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On 12.06.2014 12:32, Robert Richter wrote: > On 28.05.14 09:39:27, Tomasz Nowicki wrote: >> +config ACPI_APEI_NMI >> + bool "NMI error notification support" >> + default y >> + depends on ACPI_APEI_GHES && X86 >> + help >> + Firmware first mode can use NMI notification mechanism to report errors >> + to operating system. This feature is currently supported by X86 >> + architecture only. >> + > > This selection is not necessary. I don't see why one should select > this at all. It's either there for an arch or not. Just use ARCH_HAS_ > style and and hard select ARCH_HAS_ACPI_APEI_NMI for x86. There is no > need for the ACPI_APEI_GHES dependency then. > It does make sense to me, will address your comment appropriately. Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/apei/Kconfig b/drivers/acpi/apei/Kconfig index c4dac71..4b734a2 100644 --- a/drivers/acpi/apei/Kconfig +++ b/drivers/acpi/apei/Kconfig @@ -3,7 +3,6 @@ config ACPI_APEI select MISC_FILESYSTEMS select PSTORE select UEFI_CPER - depends on X86 help APEI allows to report errors (for example from the chipset) to the operating system. This improves NMI handling @@ -26,6 +25,15 @@ config ACPI_APEI_GHES by firmware to produce more valuable hardware error information for Linux. +config ACPI_APEI_NMI + bool "NMI error notification support" + default y + depends on ACPI_APEI_GHES && X86 + help + Firmware first mode can use NMI notification mechanism to report errors + to operating system. This feature is currently supported by X86 + architecture only. + config ACPI_APEI_PCIEAER bool "APEI PCIe AER logging/recovering support" depends on ACPI_APEI && PCIEAER
Currently APEI depends on x86 architecture. It is because of NMI hardware error notification of GHES which is currently supported by x86 only. However, many other APEI features can be still used perfectly by other architectures. This commit adds ACPI_APEI_NMI which will be used in next patches to isolate NMI related code in ghes.c file. Only NMI error notification feature depends on x86 and it is selected by default for x86 arch. Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org> --- drivers/acpi/apei/Kconfig | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)