| Message ID | 20201029074301.226644-24-coiby.xu@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Thu, Oct 29, 2020 at 03:43:00PM +0800, Coiby Xu wrote: > SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu <coiby.xu@gmail.com> > --- > sound/soc/codecs/wm8994.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c > index fc9ea198ac79..9294ad06f76d 100644 > --- a/sound/soc/codecs/wm8994.c > +++ b/sound/soc/codecs/wm8994.c > @@ -4656,7 +4656,6 @@ static int wm8994_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int wm8994_suspend(struct device *dev) > { > struct wm8994_priv *wm8994 = dev_get_drvdata(dev); > @@ -4681,7 +4680,6 @@ static int wm8994_resume(struct device *dev) > > return 0; > } > -#endif > > static const struct dev_pm_ops wm8994_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(wm8994_suspend, wm8994_resume) Not sure this really makes sense, what is going to stop the unused function warning if PM isn't configured? Thanks, Charles
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c index fc9ea198ac79..9294ad06f76d 100644 --- a/sound/soc/codecs/wm8994.c +++ b/sound/soc/codecs/wm8994.c @@ -4656,7 +4656,6 @@ static int wm8994_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP static int wm8994_suspend(struct device *dev) { struct wm8994_priv *wm8994 = dev_get_drvdata(dev); @@ -4681,7 +4680,6 @@ static int wm8994_resume(struct device *dev) return 0; } -#endif static const struct dev_pm_ops wm8994_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(wm8994_suspend, wm8994_resume)
SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. Signed-off-by: Coiby Xu <coiby.xu@gmail.com> --- sound/soc/codecs/wm8994.c | 2 -- 1 file changed, 2 deletions(-)