| Message ID | 20201029075236.228335-1-coiby.xu@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP | expand |
On Thu, Oct 29, 2020 at 03:52:34PM +0800, Coiby Xu wrote: > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. Doesn't it result in "defined but not used" warnings if you compile without CONFIG_PM? I believe if you are dropping #ifdef guards you need to add __maybe_unused annotations. > Signed-off-by: Coiby Xu <coiby.xu@gmail.com> > --- > drivers/input/keyboard/pmic8xxx-keypad.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c > index 91d5811d6f0e..c04ab04331b2 100644 > --- a/drivers/input/keyboard/pmic8xxx-keypad.c > +++ b/drivers/input/keyboard/pmic8xxx-keypad.c > @@ -621,7 +621,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int pmic8xxx_kp_suspend(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > @@ -661,7 +660,6 @@ static int pmic8xxx_kp_resume(struct device *dev) > > return 0; > } > -#endif > > static SIMPLE_DEV_PM_OPS(pm8xxx_kp_pm_ops, > pmic8xxx_kp_suspend, pmic8xxx_kp_resume); > -- > 2.28.0 > Thanks. -- Dmitry
diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c index 91d5811d6f0e..c04ab04331b2 100644 --- a/drivers/input/keyboard/pmic8xxx-keypad.c +++ b/drivers/input/keyboard/pmic8xxx-keypad.c @@ -621,7 +621,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP static int pmic8xxx_kp_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); @@ -661,7 +660,6 @@ static int pmic8xxx_kp_resume(struct device *dev) return 0; } -#endif static SIMPLE_DEV_PM_OPS(pm8xxx_kp_pm_ops, pmic8xxx_kp_suspend, pmic8xxx_kp_resume);
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. Signed-off-by: Coiby Xu <coiby.xu@gmail.com> --- drivers/input/keyboard/pmic8xxx-keypad.c | 2 -- 1 file changed, 2 deletions(-)