| Message ID | 1401989458-450-1-git-send-email-peter.griffin@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Thu, Jun 05, 2014 at 06:30:57PM +0100, Peter Griffin wrote: > The C99 specification states in section 6.11.5: > > The placement of a storage-class specifier other than at the beginning > of the declaration specifiers in a declaration is an obsolescent > feature. This is definitely the right change to make, but I believe Thierry already included a fix for this in patch http://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=233fd4ec92b90a2d3bb5104d17835072ba2fde4b which also cleans up some whitespace problems. Matt > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/drm_plane_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c > index d2b1c03..88a6c49 100644 > --- a/drivers/gpu/drm/drm_plane_helper.c > +++ b/drivers/gpu/drm/drm_plane_helper.c > @@ -36,7 +36,7 @@ > * creating the primary plane. However drivers that still call > * drm_plane_init() will use this minimal format list as the default. > */ > -const static uint32_t safe_modeset_formats[] = { > +static const uint32_t safe_modeset_formats[] = { > DRM_FORMAT_XRGB8888, > DRM_FORMAT_ARGB8888, > }; > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index d2b1c03..88a6c49 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c @@ -36,7 +36,7 @@ * creating the primary plane. However drivers that still call * drm_plane_init() will use this minimal format list as the default. */ -const static uint32_t safe_modeset_formats[] = { +static const uint32_t safe_modeset_formats[] = { DRM_FORMAT_XRGB8888, DRM_FORMAT_ARGB8888, };
The C99 specification states in section 6.11.5: The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/drm_plane_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)