diff mbox series

[1/4] dt-bindings: opp: Introduce opp-sustainable bindings

Message ID 20201028140847.1018-2-lukasz.luba@arm.com
State New
Headers show
Series Add sustainable OPP concept | expand

Commit Message

Lukasz Luba Oct. 28, 2020, 2:08 p.m. UTC
Add opp-sustainable as an additional property in the OPP node to describe
the sustainable performance level of the device. This will help to
estimate the sustainable performance of the whole system.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 Documentation/devicetree/bindings/opp/opp.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Nishanth Menon Oct. 28, 2020, 9:47 p.m. UTC | #1
On 14:08-20201028, Lukasz Luba wrote:
> Add opp-sustainable as an additional property in the OPP node to describe
> the sustainable performance level of the device. This will help to
> estimate the sustainable performance of the whole system.
> 
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
>  Documentation/devicetree/bindings/opp/opp.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> index 9847dfeeffcb..cd01028de305 100644
> --- a/Documentation/devicetree/bindings/opp/opp.txt
> +++ b/Documentation/devicetree/bindings/opp/opp.txt
> @@ -154,6 +154,10 @@ Optional properties:
>  - opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs
>    in the table have this, the OPP with highest opp-hz will be used.
>  
> +- opp-sustainable: Marks the OPP as sustainable. This property can be used for
> +  estimating sustainable performance of the whole system. If multiple OPPs in
> +  the table have this, the OPP with highest opp-hz will be used.


By "sustainable", do you mean sustainable across Process, Voltage and
Temperature corners upto the max rated operational Power-ON hours
without IDLE state being achieved on the processor?

OR do you mean to leave it up to interpretation?
> +
>  - opp-supported-hw: This property allows a platform to enable only a subset of
>    the OPPs from the larger set present in the OPP table, based on the current
>    version of the hardware (already known to the operating system).
> -- 
> 2.17.1
>
Rob Herring (Arm) Oct. 30, 2020, 7:34 p.m. UTC | #2
On Wed, Oct 28, 2020 at 02:08:44PM +0000, Lukasz Luba wrote:
> Add opp-sustainable as an additional property in the OPP node to describe

> the sustainable performance level of the device. This will help to

> estimate the sustainable performance of the whole system.

> 

> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>

> ---

>  Documentation/devicetree/bindings/opp/opp.txt | 4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt

> index 9847dfeeffcb..cd01028de305 100644

> --- a/Documentation/devicetree/bindings/opp/opp.txt

> +++ b/Documentation/devicetree/bindings/opp/opp.txt

> @@ -154,6 +154,10 @@ Optional properties:

>  - opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs

>    in the table have this, the OPP with highest opp-hz will be used.

>  

> +- opp-sustainable: Marks the OPP as sustainable. This property can be used for

> +  estimating sustainable performance of the whole system. If multiple OPPs in

> +  the table have this, the OPP with highest opp-hz will be used.

> +


Isn't this just the inverse of the turbo? or boost? flag we already 
have? 

Couldn't this be learned? I ran at this frequency and then overheated. 
That could be dependent on ambient temperatures or dust build up on 
fans/heatsink.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
index 9847dfeeffcb..cd01028de305 100644
--- a/Documentation/devicetree/bindings/opp/opp.txt
+++ b/Documentation/devicetree/bindings/opp/opp.txt
@@ -154,6 +154,10 @@  Optional properties:
 - opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs
   in the table have this, the OPP with highest opp-hz will be used.
 
+- opp-sustainable: Marks the OPP as sustainable. This property can be used for
+  estimating sustainable performance of the whole system. If multiple OPPs in
+  the table have this, the OPP with highest opp-hz will be used.
+
 - opp-supported-hw: This property allows a platform to enable only a subset of
   the OPPs from the larger set present in the OPP table, based on the current
   version of the hardware (already known to the operating system).