Message ID | 1402159991-13919-1-git-send-email-peter.maydell@linaro.org |
---|---|
State | Superseded |
Headers | show
Return-Path: <patchwork-forward+bncBC6Z756YVMIBB6MGZWOAKGQEDKQMGRQ@linaro.org> X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f198.google.com (mail-yk0-f198.google.com [209.85.160.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 78F9D2100A for <linaro@patches.linaro.org>; Sat, 7 Jun 2014 16:53:13 +0000 (UTC) Received: by mail-yk0-f198.google.com with SMTP id 9sf178515ykp.9 for <linaro@patches.linaro.org>; Sat, 07 Jun 2014 09:53:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=Ho9QQzi2yojhI0NgY/TrRrnlbzOgF0YhQYUgBnggzwI=; b=ONY6jCoNnk10oTlFAZrBxgD9WeqwXW9DiRqng7KPMOTU9eSzFVzmwX7AMXX8wPU8OQ nYT5C1xT171owdTqyAXv77MYm/nhwb+htzJ2L1qVxelXiLVb1+hmB/wSDONQzi4/AwyC oGMTy+i4lMlyU3nDqIhRzrfLUWrgtMhoHaIC1CHEMQJJLRElLfdGYOAxEKP7k+GaapDz Cq27XKxKMcIlPsUqqC9LO3XmLPsMXXlefjgCIeu+FL2VZShJYftSFFxNjESKm+79iL95 5wAMiNcCvPB9IK9juJbbKiktyD6L31ABWC91PQfgDDJzkkD3wF1ZHq1MD2qg9W+M6tPG yD4A== X-Gm-Message-State: ALoCoQl1AxWqtOu8cdQ5VbzXIQFdzELs4EkSjDDOGLpQBg13VTtLCdSaoUB3q+KHsK1pkOS5yPYe X-Received: by 10.236.141.11 with SMTP id f11mr849581yhj.54.1402159993268; Sat, 07 Jun 2014 09:53:13 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.40.209 with SMTP id x75ls1091159qgx.46.gmail; Sat, 07 Jun 2014 09:53:13 -0700 (PDT) X-Received: by 10.58.201.5 with SMTP id jw5mr14264833vec.6.1402159993173; Sat, 07 Jun 2014 09:53:13 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id ky16si9298006vdb.106.2014.06.07.09.53.13 for <patchwork-forward@linaro.org> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 07 Jun 2014 09:53:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id id10so2908584vcb.16 for <patchwork-forward@linaro.org>; Sat, 07 Jun 2014 09:53:13 -0700 (PDT) X-Received: by 10.220.94.146 with SMTP id z18mr12333891vcm.40.1402159993098; Sat, 07 Jun 2014 09:53:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp29512vcb; Sat, 7 Jun 2014 09:53:12 -0700 (PDT) X-Received: by 10.194.89.40 with SMTP id bl8mr4593295wjb.90.1402159992361; Sat, 07 Jun 2014 09:53:12 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id gk1si3418091wib.80.2014.06.07.09.53.11 for <patches@linaro.org> (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 07 Jun 2014 09:53:12 -0700 (PDT) Received-SPF: none (google.com: pm215@archaic.org.uk does not designate permitted sender hosts) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from <pm215@archaic.org.uk>) id 1WtJrj-0003cy-6o; Sat, 07 Jun 2014 17:53:11 +0100 From: Peter Maydell <peter.maydell@linaro.org> To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-trivial@nongnu.org Subject: [PATCH] hw/net/ne2000-isa: Register vmstate struct Date: Sat, 7 Jun 2014 17:53:11 +0100 Message-Id: <1402159991-13919-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: <patchwork-forward.linaro.org> X-Google-Group-Id: 836684582541 List-Post: <http://groups.google.com/a/linaro.org/group/patchwork-forward/post>, <mailto:patchwork-forward@linaro.org> List-Help: <http://support.google.com/a/linaro.org/bin/topic.py?topic=25838>, <mailto:patchwork-forward+help@linaro.org> List-Archive: <http://groups.google.com/a/linaro.org/group/patchwork-forward/> List-Unsubscribe: <http://groups.google.com/a/linaro.org/group/patchwork-forward/subscribe>, <mailto:googlegroups-manage+836684582541+unsubscribe@googlegroups.com> |
Applied to -trivial, thank you! /mjt
diff --git a/hw/net/ne2000-isa.c b/hw/net/ne2000-isa.c index c660e58..0a14f6d 100644 --- a/hw/net/ne2000-isa.c +++ b/hw/net/ne2000-isa.c @@ -98,6 +98,7 @@ static void isa_ne2000_class_initfn(ObjectClass *klass, void *data) dc->realize = isa_ne2000_realizefn; dc->props = ne2000_isa_properties; + dc->vmsd = &vmstate_isa_ne2000; set_bit(DEVICE_CATEGORY_NETWORK, dc->categories); }
The ne2000-isa device defines a VMState struct for migration, but we forgot to actually register it. Correct this deficiency by setting dc->vmsd. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- I think this is the last of the "oops, we didn't actually register the vmstate" bugs that clang 3.4 warns about. hw/net/ne2000-isa.c | 1 + 1 file changed, 1 insertion(+)