| Message ID | 20201031171930.GA21555@fedora-project |
|---|---|
| State | New |
| Headers | show |
| Series | usb: core: ledtrig-usbport: use octal permission | expand |
On Sat, Oct 31, 2020 at 01:19:30PM -0400, Nigel Christian wrote: > Change read/write for owner permission from symbolic to octal > to enhance readability. This patch reduces checkpatch warnings > for this file to nil. > > see: https://lkml.org/lkml/2016/8/2/1945 Please use lore.kernel.org links for mailing list stuff. thanks, greg k-h
diff --git a/drivers/usb/core/ledtrig-usbport.c b/drivers/usb/core/ledtrig-usbport.c index ba371a24ff78..8e9b1c5cc971 100644 --- a/drivers/usb/core/ledtrig-usbport.c +++ b/drivers/usb/core/ledtrig-usbport.c @@ -211,7 +211,7 @@ static int usbport_trig_add_port(struct usbport_trig_data *usbport_data, sysfs_attr_init(&port->attr.attr); port->attr.attr.name = port->port_name; - port->attr.attr.mode = S_IRUSR | S_IWUSR; + port->attr.attr.mode = 0600; port->attr.show = usbport_trig_port_show; port->attr.store = usbport_trig_port_store;
Change read/write for owner permission from symbolic to octal to enhance readability. This patch reduces checkpatch warnings for this file to nil. see: https://lkml.org/lkml/2016/8/2/1945 verified via chmod(2) man page Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com> --- drivers/usb/core/ledtrig-usbport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)