| Message ID | 20201031182144.1081847-1-andrew@lunn.ch |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: netfilter: Add __printf() attribute | expand |
On Sat, Oct 31, 2020 at 07:21:44PM +0100, Andrew Lunn wrote: > nft_request_module calls vsnprintf() using parameters passed to it. > Make the function with __printf() attribute so the compiler can check > the format and arguments. Applied, thanks.
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 65cb8e3c13d9..522a9d28754b 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -581,7 +581,8 @@ struct nft_module_request { }; #ifdef CONFIG_MODULES -static int nft_request_module(struct net *net, const char *fmt, ...) +static __printf(2, 3) int nft_request_module(struct net *net, const char *fmt, + ...) { char module_name[MODULE_NAME_LEN]; struct nft_module_request *req;
nft_request_module calls vsnprintf() using parameters passed to it. Make the function with __printf() attribute so the compiler can check the format and arguments. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- net/netfilter/nf_tables_api.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)