| Message ID | 1402394236-14778-1-git-send-email-srinivas.kandagatla@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Tue, Jun 10, 2014 at 10:57:16AM +0100, Srinivas Kandagatla wrote: > On multi_v7_defconfig using def_bool in Kconfig can override the selection > made as part of DEBUG_LL. This is because def_bool will set the config to true > if the expression evaluates to true, which is what was happening in > multi_v7_defconfig. ARCH_SPEAR13XX selects DEBUG_UART_PL01X overiding any > previous DEBUG_LL selections. > > Making the def_bool to bool and depends made sense in this case, and > fixes the issue too. NAK. 1. you haven't tested this - if you select DEBUG_BCM2835 in the choice, it will select DEBUG_UART_PL01X, which, with your patch, will not have its new dependencies satisfied. 2. there is nothing to select this debug option on the platforms which you make it depend upon. The real solution here is to convert these (and the other) remaining platforms to the choice mechanism. Same for the 8250 one.
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 8f90595..53d653c1 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1021,7 +1021,8 @@ config DEBUG_LL_INCLUDE # Compatibility options for PL01x config DEBUG_UART_PL01X - def_bool ARCH_EP93XX || \ + bool + depends on ARCH_EP93XX || \ ARCH_INTEGRATOR || \ ARCH_SPEAR3XX || \ ARCH_SPEAR6XX || \
On multi_v7_defconfig using def_bool in Kconfig can override the selection made as part of DEBUG_LL. This is because def_bool will set the config to true if the expression evaluates to true, which is what was happening in multi_v7_defconfig. ARCH_SPEAR13XX selects DEBUG_UART_PL01X overiding any previous DEBUG_LL selections. Making the def_bool to bool and depends made sense in this case, and fixes the issue too. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- arch/arm/Kconfig.debug | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)