| Message ID | 20201104131924.593522-3-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Some cleanups to build deps | expand |
On 11/4/20 2:19 PM, Daniel P. Berrangé wrote: > There is no sign of 'bc' being used by any tests in the tree. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > scripts/coverity-scan/coverity-scan.docker | 1 - > tests/docker/dockerfiles/debian10.docker | 1 - > tests/docker/dockerfiles/fedora-win32-cross.docker | 1 - > tests/docker/dockerfiles/fedora-win64-cross.docker | 1 - > tests/docker/dockerfiles/fedora.docker | 1 - > 5 files changed, 5 deletions(-) I added it to be able to rebuild easily the blobs consumed by our tests: commit 1bbf2d010fc0e5f0a9c5e1967368c44bc64e086a Author: Philippe Mathieu-Daudé <f4bug@amsat.org> Date: Mon Mar 16 17:21:28 2020 +0000 tests/docker: Install tools to cross-debug and build Linux kernels We often run Linux kernels to test QEMU. We sometimes need to build them manually to use non-default features. We only miss the tiny 'bc' tool. The ncurses library is helpful to run 'make menuconfig'. Finally, gdb-multiarch allow us to debug a TCG guest when its architecture is different than the host. I think this is related to the question of what we can include to the repository for testing... If we can not add binary and don't have how to produce them, it becomes complicated.
diff --git a/scripts/coverity-scan/coverity-scan.docker b/scripts/coverity-scan/coverity-scan.docker index ecff6ac5b4..e49c5e8332 100644 --- a/scripts/coverity-scan/coverity-scan.docker +++ b/scripts/coverity-scan/coverity-scan.docker @@ -18,7 +18,6 @@ FROM fedora:30 ENV PACKAGES \ alsa-lib-devel \ - bc \ brlapi-devel \ bzip2 \ bzip2-devel \ diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker index 21cc671d71..9f52e2ceae 100644 --- a/tests/docker/dockerfiles/debian10.docker +++ b/tests/docker/dockerfiles/debian10.docker @@ -17,7 +17,6 @@ RUN apt update && \ DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ DEBIAN_FRONTEND=noninteractive eatmydata \ apt install -y --no-install-recommends \ - bc \ build-essential \ ca-certificates \ clang \ diff --git a/tests/docker/dockerfiles/fedora-win32-cross.docker b/tests/docker/dockerfiles/fedora-win32-cross.docker index 5903e1b0b4..fccff862e1 100644 --- a/tests/docker/dockerfiles/fedora-win32-cross.docker +++ b/tests/docker/dockerfiles/fedora-win32-cross.docker @@ -2,7 +2,6 @@ FROM fedora:32 # Please keep this list sorted alphabetically ENV PACKAGES \ - bc \ bzip2 \ diffutils \ findutils \ diff --git a/tests/docker/dockerfiles/fedora-win64-cross.docker b/tests/docker/dockerfiles/fedora-win64-cross.docker index 7f03cd8ffc..67dc33df63 100644 --- a/tests/docker/dockerfiles/fedora-win64-cross.docker +++ b/tests/docker/dockerfiles/fedora-win64-cross.docker @@ -2,7 +2,6 @@ FROM fedora:32 # Please keep this list sorted alphabetically ENV PACKAGES \ - bc \ bzip2 \ diffutils \ findutils \ diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 29859beee3..0f5c76067b 100644 --- a/tests/docker/dockerfiles/fedora.docker +++ b/tests/docker/dockerfiles/fedora.docker @@ -2,7 +2,6 @@ FROM fedora:32 # Please keep this list sorted alphabetically ENV PACKAGES \ - bc \ brlapi-devel \ bzip2 \ bzip2-devel \
There is no sign of 'bc' being used by any tests in the tree. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- scripts/coverity-scan/coverity-scan.docker | 1 - tests/docker/dockerfiles/debian10.docker | 1 - tests/docker/dockerfiles/fedora-win32-cross.docker | 1 - tests/docker/dockerfiles/fedora-win64-cross.docker | 1 - tests/docker/dockerfiles/fedora.docker | 1 - 5 files changed, 5 deletions(-)