[1/4] drm/tilcdc: avoid 'make W=2' build failure

Message ID 20201026194110.3817470-1-arnd@kernel.org
State New
Headers show
Series
  • [1/4] drm/tilcdc: avoid 'make W=2' build failure
Related show

Commit Message

Arnd Bergmann Oct. 26, 2020, 7:41 p.m.
From: Arnd Bergmann <arnd@arndb.de>


The -Wmissing-field-initializer warning when building with W=2
turns into an error because tilcdc is built with -Werror:

drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "regs", tilcdc_regs_show, 0 },
drm/tilcdc/tilcdc_drv.c:432:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "mm",   tilcdc_mm_show,   0 },

Add the missing field initializers to address the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Jyri Sarha Oct. 27, 2020, 3:31 p.m. | #1
On 26/10/2020 21:41, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> The -Wmissing-field-initializer warning when building with W=2

> turns into an error because tilcdc is built with -Werror:

> 

> drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "regs", tilcdc_regs_show, 0 },

> drm/tilcdc/tilcdc_drv.c:432:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "mm",   tilcdc_mm_show,   0 },

> 

> Add the missing field initializers to address the warning.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Reviewed-by: Jyri Sarha <jsarha@ti.com>


Please let me know if you want me to merge this.

Best regards,
Jyri

> ---

>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c

> index 4f5fc3e87383..754a66051a21 100644

> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c

> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c

> @@ -428,8 +428,8 @@ static int tilcdc_mm_show(struct seq_file *m, void *arg)

>  }

>  

>  static struct drm_info_list tilcdc_debugfs_list[] = {

> -		{ "regs", tilcdc_regs_show, 0 },

> -		{ "mm",   tilcdc_mm_show,   0 },

> +		{ "regs", tilcdc_regs_show, 0, NULL },

> +		{ "mm",   tilcdc_mm_show,   0, NULL },

>  };

>  

>  static void tilcdc_debugfs_init(struct drm_minor *minor)

> 



-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Arnd Bergmann Oct. 27, 2020, 4:47 p.m. | #2
On Tue, Oct 27, 2020 at 4:31 PM Jyri Sarha <jsarha@ti.com> wrote:
> On 26/10/2020 21:41, Arnd Bergmann wrote:

> > From: Arnd Bergmann <arnd@arndb.de>

> >

> > The -Wmissing-field-initializer warning when building with W=2

> > turns into an error because tilcdc is built with -Werror:

> >

> > drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "regs", tilcdc_regs_show, 0 },

> > drm/tilcdc/tilcdc_drv.c:432:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "mm",   tilcdc_mm_show,   0 },

> >

> > Add the missing field initializers to address the warning.

> >

> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>

> Reviewed-by: Jyri Sarha <jsarha@ti.com>


Thanks

> Please let me know if you want me to merge this.


Yes, it would be good if you can merge it directly.

      Arnd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4f5fc3e87383..754a66051a21 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -428,8 +428,8 @@  static int tilcdc_mm_show(struct seq_file *m, void *arg)
 }
 
 static struct drm_info_list tilcdc_debugfs_list[] = {
-		{ "regs", tilcdc_regs_show, 0 },
-		{ "mm",   tilcdc_mm_show,   0 },
+		{ "regs", tilcdc_regs_show, 0, NULL },
+		{ "mm",   tilcdc_mm_show,   0, NULL },
 };
 
 static void tilcdc_debugfs_init(struct drm_minor *minor)