From patchwork Mon Oct 26 21:00:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 318992 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp996968ilc; Mon, 26 Oct 2020 14:01:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEwwGigsyujNgx0red9aZ/e7nCz5iiqY1wFCxjWamN39iDWHgpTsB3Y1c1ozBbaRrRDPmz X-Received: by 2002:a17:90a:d345:: with SMTP id i5mr21702249pjx.150.1603746090378; Mon, 26 Oct 2020 14:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603746090; cv=none; d=google.com; s=arc-20160816; b=pk3RLrJH6gpX6xsnUyXgfBrJB09UK7iMiQnMAUXTxT3R+YVrlrDOwULCiWwdketrUr zdiKawCKoQvagCBKNjqtx2nLWictUIu2Ohu8LC9HAyq8bj7rBqXOU58t5E3Iakjnx6Fl 3n8VJIt7tgwn8fp2Cj6aCnPIhZomCCGyJocNKXB+KAEGQNN8XMTMf9w0b50cuzYNAup3 IfKT8c2+HsXKAjULpitQw+lTZd1NLK97nBmDy5dxdoxQGPGduSpSLPUiH69VATxRYfwa j6q+9ZCFUixTClqH8ghjIJN18r9fFFG2NdA6jc1L0NApyldnNInUthS7vZisn3cnkkNp qaWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=+Tav10YcnWaQ9hOuCTWOblXIyvhO9OzObG1ytV8U2WE=; b=fIlfDB+Z17PCH30/qsg4IGLs0oshj+oXv6nboMb7W/7WtFEB8CA49+0I5mjqhNIlsp 5dbsSRi6rd3Ps02SJ2X1fM5jol39m1yz4oYO1/C5MQnFLILmAsgzwxyOcZWtVFjccSSC YKYLPs5fe6d35sIIJCL4NbNMqj3m0scvPPPnkN64zM76zU5ZehklYPmbv63a2sj/bYWA sdnCtyRcQQ2MG19SWLdjqCYCQ0UzJ+IY3uGsnDEjvmelIBeJt+un9A44k/Gw7e4mu+Sc XHwxE8B1GMfpCBjKvBsnUfMUIEeEGZ9WlLb8hfejRMZ6A4b/cgMJqUKeACf0KHSQnL9L qmqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=default header.b=LhJGZKnx; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id a6si6363167pfg.267.2020.10.26.14.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 14:01:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=default header.b=LhJGZKnx; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FF446EA6E; Mon, 26 Oct 2020 21:01:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8B116EA6E; Mon, 26 Oct 2020 21:01:27 +0000 (UTC) Received: from localhost.localdomain (unknown [192.30.34.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E32620829; Mon, 26 Oct 2020 21:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603746087; bh=MIKQiQBZmnJNoIdqgw0/BlRmOZ5SjarctyzS0l2h4+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LhJGZKnxSeOcuD6ScbAADTnR9TLfI1UtJCyMiRiDdhHRuZuvsY3YrTaDxh6sGNlq/ GJNUazGYQ518GnLMyj7JxnE+sR70RBTEk+CHDZnfJAwrk6Kz51sc2k3Eqe9KndcdNq Br42FS+wMsgrnj3jVqhMnunD5FRtHzyJ9KYNpdAU= From: Arnd Bergmann To: Harry Wentland , Leo Li , Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= , David Airlie , Daniel Vetter , Anthony Koo , Krunoslav Kovac Subject: [PATCH 4/5] drm/amdgpu: fix build_coefficients() argument Date: Mon, 26 Oct 2020 22:00:32 +0100 Message-Id: <20201026210039.3884312-4-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201026210039.3884312-1-arnd@kernel.org> References: <20201026210039.3884312-1-arnd@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lewis Huang , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Denis Efremov , Reza Amini , amd-gfx@lists.freedesktop.org, Josip Pavic , Nicholas Kazlauskas Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Arnd Bergmann gcc -Wextra warns about a function taking an enum argument being called with a bool: drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma': drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum ' to 'enum dc_transfer_func_predefined' [-Wenum-conversion] 1617 | build_coefficients(&coeff, true); It appears that a patch was added using the old calling conventions after the type was changed, and the value should actually be 0 (TRANSFER_FUNCTION_SRGB) here instead of 1 (true). Fixes: 55a01d4023ce ("drm/amd/display: Add user_regamma to color module") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Harry Wentland diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c index b8695660b480..09bc2c249e1a 100644 --- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c @@ -1614,7 +1614,7 @@ static void apply_degamma_for_user_regamma(struct pwl_float_data_ex *rgb_regamma struct pwl_float_data_ex *rgb = rgb_regamma; const struct hw_x_point *coord_x = coordinates_x; - build_coefficients(&coeff, true); + build_coefficients(&coeff, TRANSFER_FUNCTION_SRGB); i = 0; while (i != hw_points_num + 1) {