| Message ID | 20201105231912.69527-3-coiby.xu@gmail.com |
|---|---|
| State | Accepted |
| Commit | c64a6a0d4a928c63e5bc3b485552a8903a506c36 |
| Headers | show |
| Series | pinctrl: amd: debounce filter fixes | expand |
Hi, On 11/6/20 12:19 AM, Coiby Xu wrote: > RTC is 32.768kHz thus 512 RtcClk equals 15625 usec. The documentation > likely has dropped precision and that's why the driver mistakenly took > the slightly deviated value. > > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Link: https://lore.kernel.org/linux-gpio/2f4706a1-502f-75f0-9596-cc25b4933b6c@redhat.com/ > Signed-off-by: Coiby Xu <coiby.xu@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/pinctrl/pinctrl-amd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c > index d6b2b4bd337c..4aea3e05e8c6 100644 > --- a/drivers/pinctrl/pinctrl-amd.c > +++ b/drivers/pinctrl/pinctrl-amd.c > @@ -156,7 +156,7 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset, > pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF); > pin_reg &= ~BIT(DB_TMR_LARGE_OFF); > } else if (debounce < 250000) { > - time = debounce / 15600; > + time = debounce / 15625; > pin_reg |= time & DB_TMR_OUT_MASK; > pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF); > pin_reg |= BIT(DB_TMR_LARGE_OFF); >
On Fri, Nov 6, 2020 at 12:19 AM Coiby Xu <coiby.xu@gmail.com> wrote: > RTC is 32.768kHz thus 512 RtcClk equals 15625 usec. The documentation > likely has dropped precision and that's why the driver mistakenly took > the slightly deviated value. > > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Link: https://lore.kernel.org/linux-gpio/2f4706a1-502f-75f0-9596-cc25b4933b6c@redhat.com/ > Signed-off-by: Coiby Xu <coiby.xu@gmail.com> This patch applied for fixes and tagged for stable. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index d6b2b4bd337c..4aea3e05e8c6 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -156,7 +156,7 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset, pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF); pin_reg &= ~BIT(DB_TMR_LARGE_OFF); } else if (debounce < 250000) { - time = debounce / 15600; + time = debounce / 15625; pin_reg |= time & DB_TMR_OUT_MASK; pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF); pin_reg |= BIT(DB_TMR_LARGE_OFF);