diff mbox series

[6/7] drm/panfrost: dev_pm_opp_put_*() accepts NULL argument

Message ID 43be6d118201f9feb70fb030390fddce0852ab0b.1604646059.git.viresh.kumar@linaro.org
State Accepted
Commit b66ba5b5938f8a51d4cb97d1392065d09551bc75
Headers show
Series opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table | expand

Commit Message

Viresh Kumar Nov. 6, 2020, 7:03 a.m. UTC
The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
there is no need for us to carry the extra check. Drop them.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Steven Price Nov. 9, 2020, 9:17 a.m. UTC | #1
On 06/11/2020 07:03, Viresh Kumar wrote:
> The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so

> there is no need for us to carry the extra check. Drop them.

> 

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>


Reviewed-by: Steven Price <steven.price@arm.com>


> ---

>   drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----

>   1 file changed, 2 insertions(+), 4 deletions(-)

> 

> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c

> index 8ab025d0035f..97b5abc7c188 100644

> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c

> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c

> @@ -170,10 +170,8 @@ void panfrost_devfreq_fini(struct panfrost_device *pfdev)

>   		pfdevfreq->opp_of_table_added = false;

>   	}

>   

> -	if (pfdevfreq->regulators_opp_table) {

> -		dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);

> -		pfdevfreq->regulators_opp_table = NULL;

> -	}

> +	dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);

> +	pfdevfreq->regulators_opp_table = NULL;

>   }

>   

>   void panfrost_devfreq_resume(struct panfrost_device *pfdev)

>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
index 8ab025d0035f..97b5abc7c188 100644
--- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
+++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
@@ -170,10 +170,8 @@  void panfrost_devfreq_fini(struct panfrost_device *pfdev)
 		pfdevfreq->opp_of_table_added = false;
 	}
 
-	if (pfdevfreq->regulators_opp_table) {
-		dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);
-		pfdevfreq->regulators_opp_table = NULL;
-	}
+	dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);
+	pfdevfreq->regulators_opp_table = NULL;
 }
 
 void panfrost_devfreq_resume(struct panfrost_device *pfdev)