From patchwork Mon Nov 9 18:21:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320961 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1957249ilc; Mon, 9 Nov 2020 10:24:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJw29Pc6C8nGJvLK/tO0fqMRj41qgQLk6IouU3YmBkUXzxhFQrZ5SgHg7Yb1Rlfnvgz6o6bm X-Received: by 2002:adf:c14c:: with SMTP id w12mr20488634wre.40.1604946286956; Mon, 09 Nov 2020 10:24:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604946286; cv=none; d=google.com; s=arc-20160816; b=jMHL2dfyaDfq2nD5n9PMoQTS2ZOgbt6zTwnxFCHVQtmaTLEKbjg0XygBc2UxZD/lcw IQGXLdZIYacj0nTaZfAV/frVHcjmD4QHE2BaAIKx+EG1o+K7jgdvZDH0vM2jyDzuHLez 1NXLkv4expgyjEPwBkNn/nEt1mO/S6H5zUstR1eqK6GaJBh2AtdBaXZSIrexzlF42Wrs RAppofFmlpQWztXK4gtyJWhndDgrU0BAJVVHZQQ23Ao64pdkKheEifmvbQd7N2gmIbTI hnCh1IR/BkLg1yExnMyjf+ceLU96ZklHcHlTuGn0G1S/HWPD4q4bNURdJwqNuKyzTU9z 2U9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=RlXXchyRQEZZcaZqSiooFaDc8K98hvNj5TPVnE7Pr3g=; b=D9KTwsF0ox6l01GXJ00+wJ32shCiI0ChfONfMToDpBaaxnrjP5xLxqNl3GTwB541uL QphlI1WK9mT9oNJDJ+HCk3Lc5g40yky8R+K9jmtmdmt3EuiaeY2teLD4AC1hFUd5CSh3 CzrSBHoOYSfxxXT8ftSXDlXHR3dE5y85dP6gqeBmfO175v09Q3dyAwQDqZlOuG9E2yHH OOVdl6uh95HK0cIDM5RSo0pgIKA89JydQm00kUpnxWY5tixZItz2wTpzke8B04aH3oE1 H7hLDWZlBFQXQQzQncitkqS7Tb/p6jkOeqICYaH2R/sNDcEiqf9pI7/+r8t4efUV8z1x OJvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=jbMgMX52; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=pISmdvdS; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id x6si10394233wrt.191.2020.11.09.10.24.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 10:24:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=jbMgMX52; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=pISmdvdS; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RlXXchyRQEZZcaZqSiooFaDc8K98hvNj5TPVnE7Pr3g=; b=jbMgMX52vFg6gbzfcJCdcA8Wa SvasrBOcPEXqTzHuo4c8oAFU+exvn2jU4uSGWt1nMz0qZUBdZ2gcyRsK9UW9QzqRwtmpRTKlrTKlo +v5ZvPgiEeHHvGI1C/ZlAiBdnil6O1xuXpu2SuJ8cHV9BoaBAN1ojUA2/Mth0ILTcYSUzCwnFSGFM v6zkaac4KcTJ+brJK/pxCvHyONh+7HUKc9xVxD3BGJUkeAgeYXnmkk1DUlYuVSghVPsTqSqSnhA1m NweCjqS5qE066UnGMxdp89c6yubdxb48vqrD0YINgeOYHh5109YHuqoW4ZIq/eez8PJ8txDjCl2ES BvFQkY94A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcBqF-0001mF-0B; Mon, 09 Nov 2020 18:24:35 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcBoK-0000tT-OE for linux-mtd@lists.infradead.org; Mon, 09 Nov 2020 18:22:43 +0000 Received: by mail-wm1-x341.google.com with SMTP id d142so390549wmd.4 for ; Mon, 09 Nov 2020 10:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nWKR6uPZUpsHw9fLiQN+tCUhIOQtuUG869jNO4i86ZY=; b=pISmdvdSsAGV1QIK8I4/nXbvzV4BpyRg4zyUJt09AIUwDnQOACl7kVRWIlyZmqQFmu h8mZCjA7ExEBqY7UPobPGH36uZeALUfjlSpsODuSdTwFYMaHv5sYNEOJTALE1KEutu+C RgDy4EZwHHKM+WM3pVjJOo4C9KfPKSll+pNQfBMJy2sz3DSOjb8zpvjYBt2ntpWUWyVL aP28CxDBuNZ2Z4vI1+SivZCt0x7e5sXUTDaoGqw+OlhpZygKYwKxsQjw2348oRFE0DWy KO2TPj52VpVqlNk5H8ho0v0+f1qb2m/Leb1RXjg+uMmaNMiF9wqWvSzbQIq+phKexoxY ty8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nWKR6uPZUpsHw9fLiQN+tCUhIOQtuUG869jNO4i86ZY=; b=IhQJ+3igtt999Gye7kbehBGR1eVlaPEG3u4Ds/VmXHYrUe+R1p0m1IAN+lbrUf6hpa iBr0TdNQhS4RE2evzddoN5fdW2wmlQblZlEqfw6JrzzpgfQhV0TznNIkK3p5QF6avxZK lVWpMHn9Uhfjv9JRfw5Brvy+gTJFRWmaBPBbBiV+sMuFOawFpODFn31YizyzibQtdL7k 7u/032RVhgqNmK8Des+gcuyg7VZUmPHoZIi5P2gz+d19/LL6PiuaQfR4IqMOZoemI0BS +41cVkjUM3TAV2XIZk/qKzhlvjFw+vQtW6A1LudhQgwcXKL5k/iKpkCS95odCDCNBqDT ybog== X-Gm-Message-State: AOAM531zRwdC7nK5NoaJ1aNtwpOKXb/wlSyxG9/TTmsJioggy7HBcnZ4 o5WF/1CQ9TjsO1YH2zl52/WkoIsC8LxaVw7z X-Received: by 2002:a1c:5a06:: with SMTP id o6mr433586wmb.181.1604946155646; Mon, 09 Nov 2020 10:22:35 -0800 (PST) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id g186sm735365wma.1.2020.11.09.10.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 10:22:35 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH v3 11/23] mtd: ubi: eba: Fix a couple of misdocumentation issues Date: Mon, 9 Nov 2020 18:21:54 +0000 Message-Id: <20201109182206.3037326-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109182206.3037326-1-lee.jones@linaro.org> References: <20201109182206.3037326-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_132236_877094_AFADAC90 X-CRM114-Status: GOOD ( 16.01 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Miquel Raynal Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/mtd/ubi/eba.c:1304: warning: Function parameter or member 'vidb' not described in 'ubi_eba_copy_leb' drivers/mtd/ubi/eba.c:1304: warning: Excess function parameter 'vid_hdr' description in 'ubi_eba_copy_leb' drivers/mtd/ubi/eba.c:1483: warning: Function parameter or member 'ai' not described in 'print_rsvd_warning' Cc: Richard Weinberger Cc: Miquel Raynal Cc: Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org Signed-off-by: Lee Jones --- drivers/mtd/ubi/eba.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 0edecfdbd01f3..892494c8cb7c7 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -1290,7 +1290,7 @@ static int is_error_sane(int err) * @ubi: UBI device description object * @from: physical eraseblock number from where to copy * @to: physical eraseblock number where to copy - * @vid_hdr: VID header of the @from physical eraseblock + * @vidb: data structure from where the VID header is derived * * This function copies logical eraseblock from physical eraseblock @from to * physical eraseblock @to. The @vid_hdr buffer may be changed by this @@ -1463,6 +1463,7 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, /** * print_rsvd_warning - warn about not having enough reserved PEBs. * @ubi: UBI device description object + * @ai: UBI attach info object * * This is a helper function for 'ubi_eba_init()' which is called when UBI * cannot reserve enough PEBs for bad block handling. This function makes a