diff mbox series

[3/4] s5p-mfc: Use display delay and display enable std controls

Message ID 20201109173541.10016-4-stanimir.varbanov@linaro.org
State Superseded
Headers show
Series MFC private ctrls to std ctrls | expand

Commit Message

Stanimir Varbanov Nov. 9, 2020, 5:35 p.m. UTC
Use the standard display_delay and display_delay_enable controls,
the legacy private MFC controls are kept for backward compatibility.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Marek Szyprowski Nov. 17, 2020, 10:04 p.m. UTC | #1
On 09.11.2020 18:35, Stanimir Varbanov wrote:
> Use the standard display_delay and display_delay_enable controls,

> the legacy private MFC controls are kept for backward compatibility.

>

> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>   drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 16 ++++++++++++++++

>   1 file changed, 16 insertions(+)

>

> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c

> index 61e144a35201..4a3e8e9bbff2 100644

> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c

> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c

> @@ -167,6 +167,13 @@ static struct mfc_control controls[] = {

>   		.step = 1,

>   		.default_value = 0,

>   	},

> +	{

> +		.id = V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY,

> +		.type = V4L2_CTRL_TYPE_INTEGER,

> +		.minimum = 0,

> +		.maximum = 16383,

> +		.default_value = 0,

> +	},

>   	{

>   		.id = V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE,

>   		.type = V4L2_CTRL_TYPE_BOOLEAN,

> @@ -176,6 +183,13 @@ static struct mfc_control controls[] = {

>   		.step = 1,

>   		.default_value = 0,

>   	},

> +	{

> +		.id = V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE,

> +		.type = V4L2_CTRL_TYPE_BOOLEAN,

> +		.minimum = 0,

> +		.maximum = 1,

> +		.default_value = 0,

> +	},

>   	{

>   		.id = V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER,

>   		.type = V4L2_CTRL_TYPE_BOOLEAN,

> @@ -690,9 +704,11 @@ static int s5p_mfc_dec_s_ctrl(struct v4l2_ctrl *ctrl)

>   

>   	switch (ctrl->id) {

>   	case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY:

> +	case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY:

>   		ctx->display_delay = ctrl->val;

>   		break;

>   	case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE:

> +	case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE:

>   		ctx->display_delay_enable = ctrl->val;

>   		break;

>   	case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER:


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland
diff mbox series

Patch

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
index 61e144a35201..4a3e8e9bbff2 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -167,6 +167,13 @@  static struct mfc_control controls[] = {
 		.step = 1,
 		.default_value = 0,
 	},
+	{
+		.id = V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY,
+		.type = V4L2_CTRL_TYPE_INTEGER,
+		.minimum = 0,
+		.maximum = 16383,
+		.default_value = 0,
+	},
 	{
 		.id = V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE,
 		.type = V4L2_CTRL_TYPE_BOOLEAN,
@@ -176,6 +183,13 @@  static struct mfc_control controls[] = {
 		.step = 1,
 		.default_value = 0,
 	},
+	{
+		.id = V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE,
+		.type = V4L2_CTRL_TYPE_BOOLEAN,
+		.minimum = 0,
+		.maximum = 1,
+		.default_value = 0,
+	},
 	{
 		.id = V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER,
 		.type = V4L2_CTRL_TYPE_BOOLEAN,
@@ -690,9 +704,11 @@  static int s5p_mfc_dec_s_ctrl(struct v4l2_ctrl *ctrl)
 
 	switch (ctrl->id) {
 	case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY:
+	case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY:
 		ctx->display_delay = ctrl->val;
 		break;
 	case V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE:
+	case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE:
 		ctx->display_delay_enable = ctrl->val;
 		break;
 	case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER: