diff mbox series

net: pch_gbe: remove unneeded variable retval in __pch_gbe_suspend

Message ID 1604837580-12419-1-git-send-email-kaixuxia@tencent.com
State New
Headers show
Series net: pch_gbe: remove unneeded variable retval in __pch_gbe_suspend | expand

Commit Message

xiakaixu1987@gmail.com Nov. 8, 2020, 12:13 p.m. UTC 
From: Kaixu Xia <kaixuxia@tencent.com>

Fix the following coccicheck warning:

./drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2415:5-11: Unneeded variable: "retval". Return "0" on line 2435

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jakub Kicinski Nov. 10, 2020, 11:27 p.m. UTC | #1 
On Sun,  8 Nov 2020 20:13:00 +0800 xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>

> 

> Fix the following coccicheck warning:

> 

> ./drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2415:5-11: Unneeded variable: "retval". Return "0" on line 2435

> 

> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>

> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>


Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index ade8c44c01cd..b9e32e4478a8 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2412,7 +2412,6 @@  static int __pch_gbe_suspend(struct pci_dev *pdev)
 	struct pch_gbe_adapter *adapter = netdev_priv(netdev);
 	struct pch_gbe_hw *hw = &adapter->hw;
 	u32 wufc = adapter->wake_up_evt;
-	int retval = 0;
 
 	netif_device_detach(netdev);
 	if (netif_running(netdev))
@@ -2432,7 +2431,7 @@  static int __pch_gbe_suspend(struct pci_dev *pdev)
 		pch_gbe_mac_set_wol_event(hw, wufc);
 		pci_disable_device(pdev);
 	}
-	return retval;
+	return 0;
 }
 
 #ifdef CONFIG_PM