diff mbox series

[v2,1/8] venus: hfi: Use correct state in unload resources

Message ID 20201111143755.24541-2-stanimir.varbanov@linaro.org
State New
Headers show
Series [v2,1/8] venus: hfi: Use correct state in unload resources | expand

Commit Message

Stanimir Varbanov Nov. 11, 2020, 2:37 p.m. UTC
INST_RELEASE_RESOURCES state is set but not used, correct this
by enter into INIT state once the unload resources is done.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/media/platform/qcom/venus/hfi.c | 2 +-
 drivers/media/platform/qcom/venus/hfi.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Fritz Koenig Nov. 29, 2020, 6:02 a.m. UTC | #1
On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
>

> INST_RELEASE_RESOURCES state is set but not used, correct this

> by enter into INIT state once the unload resources is done.

>

> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

> ---

>  drivers/media/platform/qcom/venus/hfi.c | 2 +-

>  drivers/media/platform/qcom/venus/hfi.h | 1 -

>  2 files changed, 1 insertion(+), 2 deletions(-)

>

> diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c

> index 638ed5cfe05e..4c87228e8e1d 100644

> --- a/drivers/media/platform/qcom/venus/hfi.c

> +++ b/drivers/media/platform/qcom/venus/hfi.c

> @@ -388,7 +388,7 @@ int hfi_session_unload_res(struct venus_inst *inst)

>         if (ret)

>                 return ret;

>

> -       inst->state = INST_RELEASE_RESOURCES;

> +       inst->state = INST_INIT;

>

>         return 0;

>  }

> diff --git a/drivers/media/platform/qcom/venus/hfi.h b/drivers/media/platform/qcom/venus/hfi.h

> index f25d412d6553..e9c944271cc1 100644

> --- a/drivers/media/platform/qcom/venus/hfi.h

> +++ b/drivers/media/platform/qcom/venus/hfi.h

> @@ -87,7 +87,6 @@ struct hfi_event_data {

>  #define INST_LOAD_RESOURCES                    4

>  #define INST_START                             5

>  #define INST_STOP                              6

> -#define INST_RELEASE_RESOURCES                 7

>

>  struct venus_core;

>  struct venus_inst;

> --

> 2.17.1

>


Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c
index 638ed5cfe05e..4c87228e8e1d 100644
--- a/drivers/media/platform/qcom/venus/hfi.c
+++ b/drivers/media/platform/qcom/venus/hfi.c
@@ -388,7 +388,7 @@  int hfi_session_unload_res(struct venus_inst *inst)
 	if (ret)
 		return ret;
 
-	inst->state = INST_RELEASE_RESOURCES;
+	inst->state = INST_INIT;
 
 	return 0;
 }
diff --git a/drivers/media/platform/qcom/venus/hfi.h b/drivers/media/platform/qcom/venus/hfi.h
index f25d412d6553..e9c944271cc1 100644
--- a/drivers/media/platform/qcom/venus/hfi.h
+++ b/drivers/media/platform/qcom/venus/hfi.h
@@ -87,7 +87,6 @@  struct hfi_event_data {
 #define INST_LOAD_RESOURCES			4
 #define INST_START				5
 #define INST_STOP				6
-#define INST_RELEASE_RESOURCES			7
 
 struct venus_core;
 struct venus_inst;