| Message ID | 1403634363-18032-1-git-send-email-trevor.woerner@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hey Trevor: I was just working on this one the other day (I have a bbappend for my xorg image) and added some pam deps, but not as "hard" deps (since pam is an optional feature). One issue I just hit in my master branch build was missing pam plugins for lxdm login, even with the pam feature enabled. see this lxdm commit <https://github.com/sarnold/meta-alt-desktop-extras/commit/05bc68e37e45a0d980b96e5fd93adeb5a9b9f33e> Maybe it's helpful, maybe not... Steve aka mr_science On Tue, Jun 24, 2014 at 11:26 AM, Trevor Woerner <trevor.woerner@linaro.org> wrote: > Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org> > --- > meta-oe/recipes-graphics/lxdm/lxdm_git.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb > b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb > index dc40fb2..d0eb516 100644 > --- a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb > +++ b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb > @@ -16,7 +16,7 @@ SRCREV = "07fb151a99ef99318b71f3de0afbba977b1e6267" > PV = "0.5.0+git${SRCPV}" > PE = "1" > > -DEPENDS = "virtual/libintl intltool-native cairo dbus gdk-pixbuf glib-2.0 > gtk+ virtual/libx11 libxcb pango iso-codes" > +DEPENDS = "virtual/libintl intltool-native cairo dbus gdk-pixbuf glib-2.0 > gtk+ virtual/libx11 libxcb pango iso-codes libpam" > DEPENDS += "${@base_contains("DISTRO_FEATURES", "systemd", "", > "consolekit", d)}" > > # combine oe-core way with angstrom DISTRO_TYPE > -- > 2.0.0.5.gbce14aa > >
On 06/24/14 16:02, Stephen Arnold wrote: > but not as "hard" deps (since pam is an > optional feature). I wasn't 100% before sending that patch, but somehow I assumed it'd be best as a: DEPENDS += "${@base_contains("DISTRO_FEATURES", "pam"... or some such. But I put it as a hard DEPENDS because lxdm has a "--without-pam" configuration option which is not being used, so I therefore concluded lxdm always wants pam support.
Yeah, it would certainly make more sense with a packageconfig option for that; currently it doesn't work either with or without the "pam" feature due to the missing plugins. So if you want hard deps, then the plugins need to be included as rdeps. Otherwise, adding an appropriate packageconfig option to the flexible depends sounds good. I still need an init script anyway, so... Steve On Tue, Jun 24, 2014 at 1:49 PM, Trevor Woerner <trevor.woerner@linaro.org> wrote: > On 06/24/14 16:02, Stephen Arnold wrote: > > but not as "hard" deps (since pam is an > > optional feature). > > I wasn't 100% before sending that patch, but somehow I assumed it'd be > best as a: > > DEPENDS += "${@base_contains("DISTRO_FEATURES", "pam"... > > or some such. But I put it as a hard DEPENDS because lxdm has a > "--without-pam" configuration option which is not being used, so I > therefore concluded lxdm always wants pam support. >
Hi Steve, On 25 June 2014 00:16, Stephen Arnold <stephen.arnold42@gmail.com> wrote: > Yeah, it would certainly make more sense with a packageconfig option for > that; currently it doesn't work either with or without the "pam" feature due > to the missing plugins. So if you want hard deps, then the plugins need to > be included as rdeps. Otherwise, adding an appropriate packageconfig option > to the flexible depends sounds good. > > I still need an init script anyway, so... Just curious to know if you're still working on this? It doesn't look to me as though pam is optional with lxdm (?) Best regards, Trevor
Hi Trevor: Not for a few days anyway, I got side-tracked with auditing Behan's course this week (among other things) but I could add some of the things we talked about if you're okay with that. Can we chat about it on IRC either later today or tomorrow maybe? Otherwise I'll take a look this weekend and see what makes sense. I guess I need to warp my brain away from risk management and think about OE stuff again... Steve On Thu, Jul 10, 2014 at 8:09 AM, Trevor Woerner <trevor.woerner@linaro.org> wrote: > Hi Steve, > > On 25 June 2014 00:16, Stephen Arnold <stephen.arnold42@gmail.com> wrote: > > Yeah, it would certainly make more sense with a packageconfig option for > > that; currently it doesn't work either with or without the "pam" feature > due > > to the missing plugins. So if you want hard deps, then the plugins need > to > > be included as rdeps. Otherwise, adding an appropriate packageconfig > option > > to the flexible depends sounds good. > > > > I still need an init script anyway, so... > > Just curious to know if you're still working on this? It doesn't look > to me as though pam is optional with lxdm (?) > > Best regards, > Trevor >
In theory pam optional, as it's a configure option (and it's been a USE flag forever). I don't use systemd, bu I would guess the systemd login manager might work on its own (ie, without pam). Not sure if lxdm supports remote auth or whatever, but for now I'll assume that pam is optional and test what I can. I'll let you test the systemd version... ;) Steve On Thu, Jul 10, 2014 at 8:09 AM, Trevor Woerner <trevor.woerner@linaro.org> wrote: > Hi Steve, > > On 25 June 2014 00:16, Stephen Arnold <stephen.arnold42@gmail.com> wrote: > > Yeah, it would certainly make more sense with a packageconfig option for > > that; currently it doesn't work either with or without the "pam" feature > due > > to the missing plugins. So if you want hard deps, then the plugins need > to > > be included as rdeps. Otherwise, adding an appropriate packageconfig > option > > to the flexible depends sounds good. > > > > I still need an init script anyway, so... > > Just curious to know if you're still working on this? It doesn't look > to me as though pam is optional with lxdm (?) > > Best regards, > Trevor >
diff --git a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb index dc40fb2..d0eb516 100644 --- a/meta-oe/recipes-graphics/lxdm/lxdm_git.bb +++ b/meta-oe/recipes-graphics/lxdm/lxdm_git.bb @@ -16,7 +16,7 @@ SRCREV = "07fb151a99ef99318b71f3de0afbba977b1e6267" PV = "0.5.0+git${SRCPV}" PE = "1" -DEPENDS = "virtual/libintl intltool-native cairo dbus gdk-pixbuf glib-2.0 gtk+ virtual/libx11 libxcb pango iso-codes" +DEPENDS = "virtual/libintl intltool-native cairo dbus gdk-pixbuf glib-2.0 gtk+ virtual/libx11 libxcb pango iso-codes libpam" DEPENDS += "${@base_contains("DISTRO_FEATURES", "systemd", "", "consolekit", d)}" # combine oe-core way with angstrom DISTRO_TYPE
Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org> --- meta-oe/recipes-graphics/lxdm/lxdm_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)