| Message ID | 1403687648-29082-3-git-send-email-zhangfei.gao@linaro.org |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi, On Wednesday 25 June 2014 02:44 PM, Zhangfei Gao wrote: > From: Jiancheng Xue <xuejiancheng@huawei.com> > > Add hix5hd2-sata-phy driver on Hisilicon hix5hd2 soc. > > Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> > Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> > --- > drivers/phy/Kconfig | 8 ++ > drivers/phy/Makefile | 1 + > drivers/phy/phy-hix5hd2-sata.c | 192 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 201 insertions(+) > create mode 100644 drivers/phy/phy-hix5hd2-sata.c > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 16a2f06..782953d 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -109,6 +109,14 @@ config PHY_EXYNOS5250_SATA > SATA 3.0 Gb/s, SATA 6.0 Gb/s speeds. It supports one SATA host > port to accept one SATA device. > > +config PHY_HIX5HD2_SATA > + tristate "HIX5HD2 SATA PHY Driver" > + depends on ARCH_HIX5HD2 && OF depends on HAS_IOMEM? > + select GENERIC_PHY > + select MFD_SYSCON > + help > + Support for SATA PHY on Hisilicon hix5hd2 Soc. > + > config PHY_SUN4I_USB > tristate "Allwinner sunxi SoC USB PHY driver" > depends on ARCH_SUNXI && HAS_IOMEM && OF > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile > index b4f1d57..54f04d0 100644 > --- a/drivers/phy/Makefile > +++ b/drivers/phy/Makefile > @@ -12,6 +12,7 @@ obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o > obj-$(CONFIG_TI_PIPE3) += phy-ti-pipe3.o > obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o > obj-$(CONFIG_PHY_EXYNOS5250_SATA) += phy-exynos5250-sata.o > +obj-$(CONFIG_PHY_HIX5HD2_SATA) += phy-hix5hd2-sata.o > obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o > obj-$(CONFIG_PHY_SAMSUNG_USB2) += phy-exynos-usb2.o > phy-exynos-usb2-y += phy-samsung-usb2.o > diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c > new file mode 100644 > index 0000000..6f1e3ea > --- /dev/null > +++ b/drivers/phy/phy-hix5hd2-sata.c > @@ -0,0 +1,192 @@ > +/* > + * Copyright (c) 2014 Linaro Ltd. > + * Copyright (c) 2014 Hisilicon Limited. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > + > +#include <linux/module.h> > +#include <linux/mfd/syscon.h> > +#include <linux/regmap.h> > +#include <linux/phy/phy.h> > +#include <linux/io.h> > +#include <linux/platform_device.h> > +#include <linux/delay.h> can this be arranged alphabetically? Helps while adding new header files. > + > +#define SATA_PHY0_CTLL 0xa0 > +#define MPLL_MULTIPLIER_SHIFT 1 > +#define MPLL_MULTIPLIER_MASK 0xfe > +#define MPLL_MULTIPLIER_50M 0x3c > +#define MPLL_MULTIPLIER_100M 0x1e > +#define PHY_RESET BIT(0) > +#define REF_SSP_EN BIT(9) > +#define SSC_EN BIT(10) > +#define REF_USE_PAD BIT(23) > + > +#define SATA_PORT_PHYCTL 0x174 > +#define SPEED_MODE_MASK 0x6f0000 > +#define HALF_RATE_SHIFT 16 > +#define PHY_CONFIG_SHIFT 18 > +#define GEN2_EN_SHIFT 21 > +#define SPEED_CTRL BIT(20) > + > +#define SATA_PORT_PHYCTL1 0x148 > +#define AMPLITUDE_MASK 0x3ffffe > +#define AMPLITUDE_GEN3 0x68 > +#define AMPLITUDE_GEN3_SHIFT 15 > +#define AMPLITUDE_GEN2 0x56 > +#define AMPLITUDE_GEN2_SHIFT 8 > +#define AMPLITUDE_GEN1 0x56 > +#define AMPLITUDE_GEN1_SHIFT 1 > + . . <snip> . . > + > +static int hix5hd2_sata_phy_probe(struct platform_device *pdev) > +{ > + struct phy_provider *phy_provider; > + struct device *dev = &pdev->dev; > + struct resource *res; > + struct phy *phy; > + struct hix5hd2_priv *priv; > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + priv->base = devm_ioremap(dev, res->start, resource_size(res)); > + if (!priv->base) > + return -ENOMEM; > + > + priv->peri_ctrl = syscon_regmap_lookup_by_phandle(dev->of_node, > + "hisilicon,peripheral-syscon"); > + if (IS_ERR(priv->peri_ctrl)) > + priv->peri_ctrl = NULL; if syscon_regmap_lookup_by_phandle returns EPROBE_DEFER, you have to return EPROBE_DEFER no? Rest looks fine to me. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wednesday 02 July 2014 04:55 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 25 June 2014 02:44 PM, Zhangfei Gao wrote: >> From: Jiancheng Xue <xuejiancheng@huawei.com> >> >> Add hix5hd2-sata-phy driver on Hisilicon hix5hd2 soc. >> >> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> >> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> >> --- >> drivers/phy/Kconfig | 8 ++ >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-hix5hd2-sata.c | 192 ++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 201 insertions(+) >> create mode 100644 drivers/phy/phy-hix5hd2-sata.c >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index 16a2f06..782953d 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -109,6 +109,14 @@ config PHY_EXYNOS5250_SATA >> SATA 3.0 Gb/s, SATA 6.0 Gb/s speeds. It supports one SATA host >> port to accept one SATA device. >> >> +config PHY_HIX5HD2_SATA >> + tristate "HIX5HD2 SATA PHY Driver" >> + depends on ARCH_HIX5HD2 && OF > > depends on HAS_IOMEM? >> + select GENERIC_PHY >> + select MFD_SYSCON >> + help >> + Support for SATA PHY on Hisilicon hix5hd2 Soc. >> + >> config PHY_SUN4I_USB >> tristate "Allwinner sunxi SoC USB PHY driver" >> depends on ARCH_SUNXI && HAS_IOMEM && OF >> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile >> index b4f1d57..54f04d0 100644 >> --- a/drivers/phy/Makefile >> +++ b/drivers/phy/Makefile >> @@ -12,6 +12,7 @@ obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o >> obj-$(CONFIG_TI_PIPE3) += phy-ti-pipe3.o >> obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o >> obj-$(CONFIG_PHY_EXYNOS5250_SATA) += phy-exynos5250-sata.o >> +obj-$(CONFIG_PHY_HIX5HD2_SATA) += phy-hix5hd2-sata.o >> obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o >> obj-$(CONFIG_PHY_SAMSUNG_USB2) += phy-exynos-usb2.o >> phy-exynos-usb2-y += phy-samsung-usb2.o >> diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c >> new file mode 100644 >> index 0000000..6f1e3ea >> --- /dev/null >> +++ b/drivers/phy/phy-hix5hd2-sata.c >> @@ -0,0 +1,192 @@ >> +/* >> + * Copyright (c) 2014 Linaro Ltd. >> + * Copyright (c) 2014 Hisilicon Limited. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + */ >> + >> +#include <linux/module.h> >> +#include <linux/mfd/syscon.h> >> +#include <linux/regmap.h> >> +#include <linux/phy/phy.h> >> +#include <linux/io.h> >> +#include <linux/platform_device.h> >> +#include <linux/delay.h> > > can this be arranged alphabetically? Helps while adding new header files. >> + >> +#define SATA_PHY0_CTLL 0xa0 >> +#define MPLL_MULTIPLIER_SHIFT 1 >> +#define MPLL_MULTIPLIER_MASK 0xfe >> +#define MPLL_MULTIPLIER_50M 0x3c >> +#define MPLL_MULTIPLIER_100M 0x1e >> +#define PHY_RESET BIT(0) >> +#define REF_SSP_EN BIT(9) >> +#define SSC_EN BIT(10) >> +#define REF_USE_PAD BIT(23) >> + >> +#define SATA_PORT_PHYCTL 0x174 >> +#define SPEED_MODE_MASK 0x6f0000 >> +#define HALF_RATE_SHIFT 16 >> +#define PHY_CONFIG_SHIFT 18 >> +#define GEN2_EN_SHIFT 21 >> +#define SPEED_CTRL BIT(20) >> + >> +#define SATA_PORT_PHYCTL1 0x148 >> +#define AMPLITUDE_MASK 0x3ffffe >> +#define AMPLITUDE_GEN3 0x68 >> +#define AMPLITUDE_GEN3_SHIFT 15 >> +#define AMPLITUDE_GEN2 0x56 >> +#define AMPLITUDE_GEN2_SHIFT 8 >> +#define AMPLITUDE_GEN1 0x56 >> +#define AMPLITUDE_GEN1_SHIFT 1 >> + > . > . > <snip> > . > . >> + >> +static int hix5hd2_sata_phy_probe(struct platform_device *pdev) >> +{ >> + struct phy_provider *phy_provider; >> + struct device *dev = &pdev->dev; >> + struct resource *res; >> + struct phy *phy; >> + struct hix5hd2_priv *priv; >> + >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >> + if (!priv) >> + return -ENOMEM; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + priv->base = devm_ioremap(dev, res->start, resource_size(res)); It should be devm_ioremap_resource(). -Kishon >> + if (!priv->base) >> + return -ENOMEM; >> + >> + priv->peri_ctrl = syscon_regmap_lookup_by_phandle(dev->of_node, >> + "hisilicon,peripheral-syscon"); >> + if (IS_ERR(priv->peri_ctrl)) >> + priv->peri_ctrl = NULL; > > if syscon_regmap_lookup_by_phandle returns EPROBE_DEFER, you have to return > EPROBE_DEFER no? > > Rest looks fine to me. > > Thanks > Kishon > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Kishon On 07/02/2014 07:26 PM, Kishon Vijay Abraham I wrote: >>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >>> index 16a2f06..782953d 100644 >>> --- a/drivers/phy/Kconfig >>> +++ b/drivers/phy/Kconfig >>> @@ -109,6 +109,14 @@ config PHY_EXYNOS5250_SATA >>> SATA 3.0 Gb/s, SATA 6.0 Gb/s speeds. It supports one SATA host >>> port to accept one SATA device. >>> >>> +config PHY_HIX5HD2_SATA >>> + tristate "HIX5HD2 SATA PHY Driver" >>> + depends on ARCH_HIX5HD2 && OF >> >> depends on HAS_IOMEM? Yes, will add it. HAS_IOMEM is select by default and not notice it at all. >>> + select GENERIC_PHY >>> + select MFD_SYSCON >>> + help >>> + Support for SATA PHY on Hisilicon hix5hd2 Soc. >>> + >>> config PHY_SUN4I_USB >>> tristate "Allwinner sunxi SoC USB PHY driver" >>> depends on ARCH_SUNXI && HAS_IOMEM && OF >>> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile >>> index b4f1d57..54f04d0 100644 >>> --- a/drivers/phy/Makefile >>> +++ b/drivers/phy/Makefile >>> @@ -12,6 +12,7 @@ obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o >>> obj-$(CONFIG_TI_PIPE3) += phy-ti-pipe3.o >>> obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o >>> obj-$(CONFIG_PHY_EXYNOS5250_SATA) += phy-exynos5250-sata.o >>> +obj-$(CONFIG_PHY_HIX5HD2_SATA) += phy-hix5hd2-sata.o >>> obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o >>> obj-$(CONFIG_PHY_SAMSUNG_USB2) += phy-exynos-usb2.o >>> phy-exynos-usb2-y += phy-samsung-usb2.o >>> diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c >>> new file mode 100644 >>> index 0000000..6f1e3ea >>> --- /dev/null >>> +++ b/drivers/phy/phy-hix5hd2-sata.c >>> @@ -0,0 +1,192 @@ >>> +/* >>> + * Copyright (c) 2014 Linaro Ltd. >>> + * Copyright (c) 2014 Hisilicon Limited. >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + */ >>> + >>> +#include <linux/module.h> >>> +#include <linux/mfd/syscon.h> >>> +#include <linux/regmap.h> >>> +#include <linux/phy/phy.h> >>> +#include <linux/io.h> >>> +#include <linux/platform_device.h> >>> +#include <linux/delay.h> >> >> can this be arranged alphabetically? Helps while adding new header files. Sure >>> +static int hix5hd2_sata_phy_probe(struct platform_device *pdev) >>> +{ >>> + struct phy_provider *phy_provider; >>> + struct device *dev = &pdev->dev; >>> + struct resource *res; >>> + struct phy *phy; >>> + struct hix5hd2_priv *priv; >>> + >>> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >>> + if (!priv) >>> + return -ENOMEM; >>> + >>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> + priv->base = devm_ioremap(dev, res->start, resource_size(res)); > > It should be devm_ioremap_resource(). Since these memory region shared by other device, devm_ioremap_resource will fail, since devm_request_mem_region. > > -Kishon >>> + if (!priv->base) >>> + return -ENOMEM; >>> + >>> + priv->peri_ctrl = syscon_regmap_lookup_by_phandle(dev->of_node, >>> + "hisilicon,peripheral-syscon"); >>> + if (IS_ERR(priv->peri_ctrl)) >>> + priv->peri_ctrl = NULL; >> >> if syscon_regmap_lookup_by_phandle returns EPROBE_DEFER, you have to return >> EPROBE_DEFER no? Sure, However, postcore_initcall(syscon_init) is bound to init before module_platform_driver probe, so EPROBE_DEFER will not occur. >> >> Rest looks fine to me. >> >> Thanks >> Kishon >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 16a2f06..782953d 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -109,6 +109,14 @@ config PHY_EXYNOS5250_SATA SATA 3.0 Gb/s, SATA 6.0 Gb/s speeds. It supports one SATA host port to accept one SATA device. +config PHY_HIX5HD2_SATA + tristate "HIX5HD2 SATA PHY Driver" + depends on ARCH_HIX5HD2 && OF + select GENERIC_PHY + select MFD_SYSCON + help + Support for SATA PHY on Hisilicon hix5hd2 Soc. + config PHY_SUN4I_USB tristate "Allwinner sunxi SoC USB PHY driver" depends on ARCH_SUNXI && HAS_IOMEM && OF diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index b4f1d57..54f04d0 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -12,6 +12,7 @@ obj-$(CONFIG_OMAP_USB2) += phy-omap-usb2.o obj-$(CONFIG_TI_PIPE3) += phy-ti-pipe3.o obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o obj-$(CONFIG_PHY_EXYNOS5250_SATA) += phy-exynos5250-sata.o +obj-$(CONFIG_PHY_HIX5HD2_SATA) += phy-hix5hd2-sata.o obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o obj-$(CONFIG_PHY_SAMSUNG_USB2) += phy-exynos-usb2.o phy-exynos-usb2-y += phy-samsung-usb2.o diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c new file mode 100644 index 0000000..6f1e3ea --- /dev/null +++ b/drivers/phy/phy-hix5hd2-sata.c @@ -0,0 +1,192 @@ +/* + * Copyright (c) 2014 Linaro Ltd. + * Copyright (c) 2014 Hisilicon Limited. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + */ + +#include <linux/module.h> +#include <linux/mfd/syscon.h> +#include <linux/regmap.h> +#include <linux/phy/phy.h> +#include <linux/io.h> +#include <linux/platform_device.h> +#include <linux/delay.h> + +#define SATA_PHY0_CTLL 0xa0 +#define MPLL_MULTIPLIER_SHIFT 1 +#define MPLL_MULTIPLIER_MASK 0xfe +#define MPLL_MULTIPLIER_50M 0x3c +#define MPLL_MULTIPLIER_100M 0x1e +#define PHY_RESET BIT(0) +#define REF_SSP_EN BIT(9) +#define SSC_EN BIT(10) +#define REF_USE_PAD BIT(23) + +#define SATA_PORT_PHYCTL 0x174 +#define SPEED_MODE_MASK 0x6f0000 +#define HALF_RATE_SHIFT 16 +#define PHY_CONFIG_SHIFT 18 +#define GEN2_EN_SHIFT 21 +#define SPEED_CTRL BIT(20) + +#define SATA_PORT_PHYCTL1 0x148 +#define AMPLITUDE_MASK 0x3ffffe +#define AMPLITUDE_GEN3 0x68 +#define AMPLITUDE_GEN3_SHIFT 15 +#define AMPLITUDE_GEN2 0x56 +#define AMPLITUDE_GEN2_SHIFT 8 +#define AMPLITUDE_GEN1 0x56 +#define AMPLITUDE_GEN1_SHIFT 1 + +#define SATA_PORT_PHYCTL2 0x14c +#define PREEMPH_MASK 0x3ffff +#define PREEMPH_GEN3 0x20 +#define PREEMPH_GEN3_SHIFT 12 +#define PREEMPH_GEN2 0x15 +#define PREEMPH_GEN2_SHIFT 6 +#define PREEMPH_GEN1 0x5 +#define PREEMPH_GEN1_SHIFT 0 + +struct hix5hd2_priv { + void __iomem *base; + struct regmap *peri_ctrl; +}; + +enum phy_speed_mode { + SPEED_MODE_GEN1 = 0, + SPEED_MODE_GEN2 = 1, + SPEED_MODE_GEN3 = 2, +}; + +static int hix5hd2_sata_phy_init(struct phy *phy) +{ + struct hix5hd2_priv *priv = phy_get_drvdata(phy); + u32 val, data[2]; + int ret; + + if (priv->peri_ctrl) { + ret = of_property_read_u32_array(phy->dev.of_node, + "hisilicon,power-reg", + &data[0], 2); + if (ret) { + dev_err(&phy->dev, "Fail read hisilicon,power-reg\n"); + return ret; + } + + regmap_update_bits(priv->peri_ctrl, data[0], + BIT(data[1]), BIT(data[1])); + } + + /* reset phy */ + val = readl_relaxed(priv->base + SATA_PHY0_CTLL); + val &= ~(MPLL_MULTIPLIER_MASK | REF_USE_PAD); + val |= MPLL_MULTIPLIER_50M << MPLL_MULTIPLIER_SHIFT | + REF_SSP_EN | PHY_RESET; + writel_relaxed(val, priv->base + SATA_PHY0_CTLL); + msleep(20); + val &= ~PHY_RESET; + writel_relaxed(val, priv->base + SATA_PHY0_CTLL); + + val = readl_relaxed(priv->base + SATA_PORT_PHYCTL1); + val &= ~AMPLITUDE_MASK; + val |= AMPLITUDE_GEN3 << AMPLITUDE_GEN3_SHIFT | + AMPLITUDE_GEN2 << AMPLITUDE_GEN2_SHIFT | + AMPLITUDE_GEN1 << AMPLITUDE_GEN1_SHIFT; + writel_relaxed(val, priv->base + SATA_PORT_PHYCTL1); + + val = readl_relaxed(priv->base + SATA_PORT_PHYCTL2); + val &= ~PREEMPH_MASK; + val |= PREEMPH_GEN3 << PREEMPH_GEN3_SHIFT | + PREEMPH_GEN2 << PREEMPH_GEN2_SHIFT | + PREEMPH_GEN1 << PREEMPH_GEN1_SHIFT; + writel_relaxed(val, priv->base + SATA_PORT_PHYCTL2); + + /* ensure PHYCTRL setting takes effect */ + val = readl_relaxed(priv->base + SATA_PORT_PHYCTL); + val &= ~SPEED_MODE_MASK; + val |= SPEED_MODE_GEN1 << HALF_RATE_SHIFT | + SPEED_MODE_GEN1 << PHY_CONFIG_SHIFT | + SPEED_MODE_GEN1 << GEN2_EN_SHIFT | SPEED_CTRL; + writel_relaxed(val, priv->base + SATA_PORT_PHYCTL); + + msleep(20); + val &= ~SPEED_MODE_MASK; + val |= SPEED_MODE_GEN3 << HALF_RATE_SHIFT | + SPEED_MODE_GEN3 << PHY_CONFIG_SHIFT | + SPEED_MODE_GEN3 << GEN2_EN_SHIFT | SPEED_CTRL; + writel_relaxed(val, priv->base + SATA_PORT_PHYCTL); + + val &= ~(SPEED_MODE_MASK | SPEED_CTRL); + val |= SPEED_MODE_GEN2 << HALF_RATE_SHIFT | + SPEED_MODE_GEN2 << PHY_CONFIG_SHIFT | + SPEED_MODE_GEN2 << GEN2_EN_SHIFT; + writel_relaxed(val, priv->base + SATA_PORT_PHYCTL); + + return 0; +} + +static struct phy_ops hix5hd2_sata_phy_ops = { + .init = hix5hd2_sata_phy_init, + .owner = THIS_MODULE, +}; + +static int hix5hd2_sata_phy_probe(struct platform_device *pdev) +{ + struct phy_provider *phy_provider; + struct device *dev = &pdev->dev; + struct resource *res; + struct phy *phy; + struct hix5hd2_priv *priv; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + priv->base = devm_ioremap(dev, res->start, resource_size(res)); + if (!priv->base) + return -ENOMEM; + + priv->peri_ctrl = syscon_regmap_lookup_by_phandle(dev->of_node, + "hisilicon,peripheral-syscon"); + if (IS_ERR(priv->peri_ctrl)) + priv->peri_ctrl = NULL; + + phy = devm_phy_create(dev, &hix5hd2_sata_phy_ops, NULL); + if (IS_ERR(phy)) { + dev_err(dev, "failed to create PHY\n"); + return PTR_ERR(phy); + } + + phy_set_drvdata(phy, priv); + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); + if (IS_ERR(phy_provider)) + return PTR_ERR(phy_provider); + + return 0; +} + +static const struct of_device_id hix5hd2_sata_phy_of_match[] = { + {.compatible = "hisilicon,hix5hd2-sata-phy",}, + { }, +}; +MODULE_DEVICE_TABLE(of, hix5hd2_sata_phy_of_match); + +static struct platform_driver hix5hd2_sata_phy_driver = { + .probe = hix5hd2_sata_phy_probe, + .driver = { + .name = "hix5hd2-sata-phy", + .owner = THIS_MODULE, + .of_match_table = hix5hd2_sata_phy_of_match, + } +}; +module_platform_driver(hix5hd2_sata_phy_driver); + +MODULE_AUTHOR("Jiancheng Xue <xuejiancheng@huawei.com>"); +MODULE_DESCRIPTION("HISILICON HIX5HD2 SATA PHY driver"); +MODULE_ALIAS("platform:hix5hd2-sata-phy"); +MODULE_LICENSE("GPL v2");