[-next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with static keyword

Message ID 1605685376-12415-1-git-send-email-zou_wei@huawei.com
State New
Headers show
Series
  • [-next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with static keyword
Related show

Commit Message

Zou Wei Nov. 18, 2020, 7:42 a.m.
Fix the following sparse warning:

drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: symbol 'lpfc_nvmet_prep_abort_wqe' was not declared. Should it be static?

Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Smart Nov. 19, 2020, 8:51 p.m. | #1
On 11/17/2020 11:42 PM, Zou Wei wrote:
> Fix the following sparse warning:

>

> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: symbol 'lpfc_nvmet_prep_abort_wqe' was not declared. Should it be static?

>

> Signed-off-by: Zou Wei <zou_wei@huawei.com>

> ---

>   drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c

> index c8b9434..a71df87 100644

> --- a/drivers/scsi/lpfc/lpfc_nvmet.c

> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c

> @@ -3336,7 +3336,7 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba,

>    *

>    * This function is called with hbalock held.

>    **/

> -void

> +static void

>   lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)

>   {

>   	union lpfc_wqe128 *wqe = &pwqeq->wqe;


Zou, Thank You .  I just submitted the same patch.   Either one Martin 
wants to take.. :)

-- james

Reviewed-by: James Smart <james.smart@broadcom.com>

Patch

diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
index c8b9434..a71df87 100644
--- a/drivers/scsi/lpfc/lpfc_nvmet.c
+++ b/drivers/scsi/lpfc/lpfc_nvmet.c
@@ -3336,7 +3336,7 @@  lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba,
  *
  * This function is called with hbalock held.
  **/
-void
+static void
 lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
 {
 	union lpfc_wqe128 *wqe = &pwqeq->wqe;