diff mbox series

[02/11] net: dsa: microchip: ksz8795: remove superfluous port_cnt assignment

Message ID 20201118220357.22292-3-m.grzeschik@pengutronix.de
State Superseded
Headers show
Series None | expand

Commit Message

Michael Grzeschik Nov. 18, 2020, 10:03 p.m. UTC 
The port_cnt assignment will be done again in the init function.
This patch removes the previous assignment in the detect function.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 drivers/net/dsa/microchip/ksz8795.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andrew Lunn Nov. 19, 2020, 12:10 a.m. UTC | #1 
On Wed, Nov 18, 2020 at 11:03:48PM +0100, Michael Grzeschik wrote:
> The port_cnt assignment will be done again in the init function.

> This patch removes the previous assignment in the detect function.

> 

> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>


Reviewed-by: Andrew Lunn <andrew@lunn.ch>


    Andrew
Florian Fainelli Nov. 19, 2020, 3:07 a.m. UTC | #2 
On 11/18/2020 2:03 PM, Michael Grzeschik wrote:
> The port_cnt assignment will be done again in the init function.

> This patch removes the previous assignment in the detect function.

> 

> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian
diff mbox series

Patch

diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c
index 8a3d2e607283581..853a0805e08f239 100644
--- a/drivers/net/dsa/microchip/ksz8795.c
+++ b/drivers/net/dsa/microchip/ksz8795.c
@@ -1152,7 +1152,6 @@  static int ksz8795_switch_detect(struct ksz_device *dev)
 
 	dev->mib_port_cnt = TOTAL_PORT_NUM;
 	dev->phy_port_cnt = SWITCH_PORT_NUM;
-	dev->port_cnt = SWITCH_PORT_NUM;
 
 	if (id2 == CHIP_ID_95) {
 		u8 val;
@@ -1162,7 +1161,6 @@  static int ksz8795_switch_detect(struct ksz_device *dev)
 		if (val & PORT_FIBER_MODE)
 			id2 = 0x65;
 	} else if (id2 == CHIP_ID_94) {
-		dev->port_cnt--;
 		id2 = 0x94;
 	}
 	id16 &= ~0xff;