| Message ID | 1404290847-7671-5-git-send-email-hanjun.guo@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wednesday, July 02, 2014 04:47:26 PM Hanjun Guo wrote: > Since EC (Embedded controller) needs SCI for the interupt which > is not available on ARM64, make the EC debugfs depend on X86 || IA64 > only in the Kconfig file. > > Reviewed-by: Grant Likely <grant.likely@linaro.org> > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> > --- > drivers/acpi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 0e6f72d..7de5e3f 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -69,6 +69,7 @@ config ACPI_PROCFS_POWER > > config ACPI_EC_DEBUGFS > tristate "EC read/write access through /sys/kernel/debug/ec" > + depends on X86 || IA64 This is totally inconsistent with the other patches in the series where you define per-arch symbols for similar things. In addition to that, do we need to build ec.c on ARM at all? > default n > help > Say N to disable Embedded Controller /sys/kernel/debug interface >
On 2014年07月08日 05:16, Rafael J. Wysocki wrote: > On Wednesday, July 02, 2014 04:47:26 PM Hanjun Guo wrote: >> Since EC (Embedded controller) needs SCI for the interupt which >> is not available on ARM64, make the EC debugfs depend on X86 || IA64 >> only in the Kconfig file. >> >> Reviewed-by: Grant Likely <grant.likely@linaro.org> >> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> >> --- >> drivers/acpi/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig >> index 0e6f72d..7de5e3f 100644 >> --- a/drivers/acpi/Kconfig >> +++ b/drivers/acpi/Kconfig >> @@ -69,6 +69,7 @@ config ACPI_PROCFS_POWER >> >> config ACPI_EC_DEBUGFS >> tristate "EC read/write access through /sys/kernel/debug/ec" >> + depends on X86 || IA64 > This is totally inconsistent with the other patches in the series where you > define per-arch symbols for similar things. In addition to that, do we need > to build ec.c on ARM at all? Yes, EC will be needed on ARM. This patch is not needed after some more consideration, I will drop it. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 0e6f72d..7de5e3f 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -69,6 +69,7 @@ config ACPI_PROCFS_POWER config ACPI_EC_DEBUGFS tristate "EC read/write access through /sys/kernel/debug/ec" + depends on X86 || IA64 default n help Say N to disable Embedded Controller /sys/kernel/debug interface