[044/141] net/mlx4: Fix fall-through warnings for Clang

Message ID 84cd69bc9b9768cf3bc032c0205ffe485b80ba03.1605896059.git.gustavoars@kernel.org
State Superseded
Headers show
Series
  • Fix fall-through warnings for Clang
Related show

Commit Message

Gustavo A. R. Silva Nov. 20, 2020, 6:31 p.m.
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tariq Toukan Nov. 22, 2020, 8:36 a.m. | #1
On 11/20/2020 8:31 PM, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

> by explicitly adding a break statement instead of just letting the code

> fall through to the next case.

> 

> Link: https://github.com/KSPP/linux/issues/115

> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

> ---

>   drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

> index 1187ef1375e2..e6b8b8dc7894 100644

> --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

> +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

> @@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,

>   	case RES_XRCD:

>   		err = xrcdn_free_res(dev, slave, vhcr->op_modifier, alop,

>   				     vhcr->in_param, &vhcr->out_param);

> +		break;

>   

>   	default:

>   		break;

> 


Reviewed-by: Tariq Toukan <tariqt@nvidia.com>


Thanks for your patch.
Gustavo A. R. Silva Nov. 23, 2020, 10:49 p.m. | #2
On Sun, Nov 22, 2020 at 10:36:01AM +0200, Tariq Toukan wrote:
> 

> 

> On 11/20/2020 8:31 PM, Gustavo A. R. Silva wrote:

> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

> > by explicitly adding a break statement instead of just letting the code

> > fall through to the next case.

> > 

> > Link: https://github.com/KSPP/linux/issues/115

> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

> > ---

> >   drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +

> >   1 file changed, 1 insertion(+)

> > 

> > diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

> > index 1187ef1375e2..e6b8b8dc7894 100644

> > --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

> > +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

> > @@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,

> >   	case RES_XRCD:

> >   		err = xrcdn_free_res(dev, slave, vhcr->op_modifier, alop,

> >   				     vhcr->in_param, &vhcr->out_param);

> > +		break;

> >   	default:

> >   		break;

> > 

> 

> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

> 

> Thanks for your patch.


Thanks, Tariq.
--
Gustavo

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
index 1187ef1375e2..e6b8b8dc7894 100644
--- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
+++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
@@ -2660,6 +2660,7 @@  int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,
 	case RES_XRCD:
 		err = xrcdn_free_res(dev, slave, vhcr->op_modifier, alop,
 				     vhcr->in_param, &vhcr->out_param);
+		break;
 
 	default:
 		break;