diff mbox series

[095/141] media: dvb_frontend: Fix fall-through warnings for Clang

Message ID 2023134a1e897bddf48e2851bdcc53706e892e6d.1605896060.git.gustavoars@kernel.org
State Accepted
Commit 97735d3a55c86cb238fa4c7469175d344df5bd26
Headers show
Series Fix fall-through warnings for Clang | expand

Commit Message

Gustavo A. R. Silva Nov. 20, 2020, 6:36 p.m. UTC
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/media/dvb-core/dvb_frontend.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mauro Carvalho Chehab Nov. 22, 2020, 4:32 p.m. UTC | #1
Em Fri, 20 Nov 2020 12:36:57 -0600
"Gustavo A. R. Silva" <gustavoars@kernel.org> escreveu:

> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning

> by explicitly adding a break statement instead of letting the code fall

> through to the next case.

> 

> Link: https://github.com/KSPP/linux/issues/115

> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>


Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>


> ---

>  drivers/media/dvb-core/dvb_frontend.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c

> index 06ea30a689d7..fb35697dd93c 100644

> --- a/drivers/media/dvb-core/dvb_frontend.c

> +++ b/drivers/media/dvb-core/dvb_frontend.c

> @@ -984,6 +984,7 @@ static int dvb_frontend_check_parameters(struct dvb_frontend *fe)

>  				 fe->ops.info.symbol_rate_max);

>  			return -EINVAL;

>  		}

> +		break;

>  	default:

>  		break;

>  	}




Thanks,
Mauro
diff mbox series

Patch

diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
index 06ea30a689d7..fb35697dd93c 100644
--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_frontend.c
@@ -984,6 +984,7 @@  static int dvb_frontend_check_parameters(struct dvb_frontend *fe)
 				 fe->ops.info.symbol_rate_max);
 			return -EINVAL;
 		}
+		break;
 	default:
 		break;
 	}